Add SetProminent() to MdTextButton to create blue buttons.

Add SetProminent() to MdTextButton to create blue buttons.

As agreed upon in https://groups.google.com/a/google.com/forum/#!topic/chrome-harmony/-VDL-TOtZVA
the API for configuring an MdTextButton to have a blue fill color shall
be SetProminent(). This cl updates the MdTextButton API to conform to this
decision.

R=sky@chromium.org
BUG=645174
Committed: https://crrev.com/49464ba3f03b6215d2c4f642d4bdf98a89b2d7df
Cr-Commit-Position: refs/heads/master@{#421379}

[shrike, 2016-09-27 16:54:14]

Description was changed from

==========
Add SetProminent() to MdTextButton to create blue buttons.

As agreed upon in
https://groups.google.com/a/google.com/forum/#!topic/chrome-harmony/-VDL-TOtZVA
the API for configuring an MdTextButton to have a blue fill color shall
be SetProminent(). This cl updates the MdTextButton API to conform to this
decision.

BUG=645174
==========

to

==========
Add SetProminent() to MdTextButton to create blue buttons.

As agreed upon in
https://groups.google.com/a/google.com/forum/#!topic/chrome-harmony/-VDL-TOtZVA
the API for configuring an MdTextButton to have a blue fill color shall
be SetProminent(). This cl updates the MdTextButton API to conform to this
decision.

R=sky@chromium.org
BUG=645174
==========

[shrike, 2016-09-27 16:54:14]

shrike@chromium.org changed reviewers:
+ sky@chromium.org

[shrike, 2016-09-27 16:54:35]

PTAL

[sky, 2016-09-27 17:38:32]

Just minor stuff.

https://codereview.chromium.org/2375543003/diff/1/chrome/browser/ui/libgtk2ui...
File chrome/browser/ui/libgtk2ui/gtk2_ui.h (right):

https://codereview.chromium.org/2375543003/diff/1/chrome/browser/ui/libgtk2ui...
chrome/browser/ui/libgtk2ui/gtk2_ui.h:155: SkColor ProminentButtonBgColor(int
gtk_state) const;
optional: prefix with Get (just like GetSelectedEntryForegroundHSL on 152
above).

https://codereview.chromium.org/2375543003/diff/1/ui/native_theme/common_them...
File ui/native_theme/common_theme.cc (right):

https://codereview.chromium.org/2375543003/diff/1/ui/native_theme/common_them...
ui/native_theme/common_theme.cc:163: static const SkColor
kTextOnProminentButtonColor = SK_ColorWHITE;
generally the 'Text' qualifier is later in the constant, e.g. kTooltipTextColor,
kColorId_ResultsTableSelectedText. How about kProminentButtonTextColor?

https://codereview.chromium.org/2375543003/diff/1/ui/views/controls/button/md...
File ui/views/controls/button/md_text_button.cc (right):

https://codereview.chromium.org/2375543003/diff/1/ui/views/controls/button/md...
ui/views/controls/button/md_text_button.cc:297: // Proinent buttons keep their
enabled text color; disabled state is conveyed
Prominent

[shrike, 2016-09-27 17:52:52]

PTAL

https://codereview.chromium.org/2375543003/diff/1/chrome/browser/ui/libgtk2ui...
File chrome/browser/ui/libgtk2ui/gtk2_ui.h (right):

https://codereview.chromium.org/2375543003/diff/1/chrome/browser/ui/libgtk2ui...
chrome/browser/ui/libgtk2ui/gtk2_ui.h:155: SkColor ProminentButtonBgColor(int
gtk_state) const;
On 2016/09/27 17:38:32, sky wrote:
> optional: prefix with Get (just like GetSelectedEntryForegroundHSL on 152
> above).

Done.

https://codereview.chromium.org/2375543003/diff/1/ui/native_theme/common_them...
File ui/native_theme/common_theme.cc (right):

https://codereview.chromium.org/2375543003/diff/1/ui/native_theme/common_them...
ui/native_theme/common_theme.cc:163: static const SkColor
kTextOnProminentButtonColor = SK_ColorWHITE;
On 2016/09/27 17:38:32, sky wrote:
> generally the 'Text' qualifier is later in the constant, e.g.
kTooltipTextColor,
> kColorId_ResultsTableSelectedText. How about kProminentButtonTextColor?

kProminentButtonTextColor is good. The convention wasn't clear (given that
kTextOnCallToActionColor was OKed), so I wasn't sure how people felt about
kProminentButtonTextColor. I have made this change.

https://codereview.chromium.org/2375543003/diff/1/ui/views/controls/button/md...
File ui/views/controls/button/md_text_button.cc (right):

https://codereview.chromium.org/2375543003/diff/1/ui/views/controls/button/md...
ui/views/controls/button/md_text_button.cc:297: // Proinent buttons keep their
enabled text color; disabled state is conveyed
On 2016/09/27 17:38:32, sky wrote:
> Prominent

Eek. Done.

[sky, 2016-09-27 22:04:27]

LGTM

[shrike, 2016-09-27 22:08:15]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-09-27 22:08:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 23:08:54]

Description was changed from

==========
Add SetProminent() to MdTextButton to create blue buttons.

As agreed upon in
https://groups.google.com/a/google.com/forum/#!topic/chrome-harmony/-VDL-TOtZVA
the API for configuring an MdTextButton to have a blue fill color shall
be SetProminent(). This cl updates the MdTextButton API to conform to this
decision.

R=sky@chromium.org
BUG=645174
==========

to

==========
Add SetProminent() to MdTextButton to create blue buttons.

As agreed upon in
https://groups.google.com/a/google.com/forum/#!topic/chrome-harmony/-VDL-TOtZVA
the API for configuring an MdTextButton to have a blue fill color shall
be SetProminent(). This cl updates the MdTextButton API to conform to this
decision.

R=sky@chromium.org
BUG=645174
==========

[commit-bot: I haz the power, 2016-09-27 23:08:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-27 23:11:07]

Description was changed from

==========
Add SetProminent() to MdTextButton to create blue buttons.

As agreed upon in
https://groups.google.com/a/google.com/forum/#!topic/chrome-harmony/-VDL-TOtZVA
the API for configuring an MdTextButton to have a blue fill color shall
be SetProminent(). This cl updates the MdTextButton API to conform to this
decision.

R=sky@chromium.org
BUG=645174
==========

to

==========
Add SetProminent() to MdTextButton to create blue buttons.

As agreed upon in
https://groups.google.com/a/google.com/forum/#!topic/chrome-harmony/-VDL-TOtZVA
the API for configuring an MdTextButton to have a blue fill color shall
be SetProminent(). This cl updates the MdTextButton API to conform to this
decision.

R=sky@chromium.org
BUG=645174

Committed: https://crrev.com/49464ba3f03b6215d2c4f642d4bdf98a89b2d7df
Cr-Commit-Position: refs/heads/master@{#421379}
==========

[commit-bot: I haz the power, 2016-09-27 23:11:08]

Patchset 2 (id:??) landed as
https://crrev.com/49464ba3f03b6215d2c4f642d4bdf98a89b2d7df
Cr-Commit-Position: refs/heads/master@{#421379}