Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2375533002:
Remove references to obsolete impl-side-painting and threaded-compositing flags. (Closed)
DescriptionRemove references to obsolete impl-side-painting and threaded-compositing flags.
Committed: https://chromium.googlesource.com/chromium/tools/build/+/4a72e8812eb2fb7051427b43d874dc94bd643098
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove --enable-threaded-compositing flag as well. #
Total comments: 4
Patch Set 3 : Remove parens. #Messages
Total messages: 19 (8 generated)
wkorman@chromium.org changed reviewers: + danakj@chromium.org, rmistry@chromium.org
Flag was removed a while ago, see http://crbug.com/413479
LGTM https://codereview.chromium.org/2375533002/diff/1/scripts/slave/recipe_module... File scripts/slave/recipe_modules/skia/resources/trigger_wait_ct_task.py (right): https://codereview.chromium.org/2375533002/diff/1/scripts/slave/recipe_module... scripts/slave/recipe_modules/skia/resources/trigger_wait_ct_task.py:81: "--disable-setuid-sandbox --enable-threaded-compositing") Can you remove the threaded-compositing too?
Description was changed from ========== Remove obsolete --enable-impl-side-painting flag. ========== to ========== Remove references to obsolete impl-side-painting and threaded-compositing flags. ==========
https://codereview.chromium.org/2375533002/diff/1/scripts/slave/recipe_module... File scripts/slave/recipe_modules/skia/resources/trigger_wait_ct_task.py (right): https://codereview.chromium.org/2375533002/diff/1/scripts/slave/recipe_module... scripts/slave/recipe_modules/skia/resources/trigger_wait_ct_task.py:81: "--disable-setuid-sandbox --enable-threaded-compositing") On 2016/09/26 21:40:16, danakj wrote: > Can you remove the threaded-compositing too? Done.
wkorman@chromium.org changed reviewers: + rmistry@google.com
+rmistry@ in case I had the wrong account initially.
Was OOO last two days. Thanks for the cleanup! LGTM https://codereview.chromium.org/2375533002/diff/20001/scripts/slave/recipe_mo... File scripts/slave/recipe_modules/skia/resources/trigger_wait_ct_task.py (right): https://codereview.chromium.org/2375533002/diff/20001/scripts/slave/recipe_mo... scripts/slave/recipe_modules/skia/resources/trigger_wait_ct_task.py:80: task_params["browser_args_nopatch"] = ("--disable-setuid-sandbox") Nit: Remove parenthesis. https://codereview.chromium.org/2375533002/diff/20001/scripts/slave/recipe_mo... scripts/slave/recipe_modules/skia/resources/trigger_wait_ct_task.py:81: task_params["browser_args_withpatch"] = ("--disable-setuid-sandbox") Nit: Remove parenthesis.
https://codereview.chromium.org/2375533002/diff/20001/scripts/slave/recipe_mo... File scripts/slave/recipe_modules/skia/resources/trigger_wait_ct_task.py (right): https://codereview.chromium.org/2375533002/diff/20001/scripts/slave/recipe_mo... scripts/slave/recipe_modules/skia/resources/trigger_wait_ct_task.py:80: task_params["browser_args_nopatch"] = ("--disable-setuid-sandbox") On 2016/09/28 11:47:28, rmistry wrote: > Nit: Remove parenthesis. Done. https://codereview.chromium.org/2375533002/diff/20001/scripts/slave/recipe_mo... scripts/slave/recipe_modules/skia/resources/trigger_wait_ct_task.py:81: task_params["browser_args_withpatch"] = ("--disable-setuid-sandbox") On 2016/09/28 11:47:28, rmistry wrote: > Nit: Remove parenthesis. Done.
The CQ bit was checked by wkorman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org, rmistry@google.com Link to the patchset: https://codereview.chromium.org/2375533002/#ps40001 (title: "Remove parens.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by rmistry@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove references to obsolete impl-side-painting and threaded-compositing flags. ========== to ========== Remove references to obsolete impl-side-painting and threaded-compositing flags. Committed: https://chromium.googlesource.com/chromium/tools/build/+/4a72e8812eb2fb705142... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/build/+/4a72e8812eb2fb705142... |
