Pass WebAPK install source to AppBannerInfobarDelegateAndroid constructor.

Pass WebAPK install source to AppBannerInfobarDelegateAndroid constructor.

This is a follow up CL for CL (https://codereview.chromium.org/2301263004).
The InstallSource is passed into the constructor of
AppBannerInfoBarDelegationAndroid, so we can call Accept() instead of
AcceptWebApk() when installing a WebAPK from add-to-homescreen menu.

BUG=626510
Committed: https://crrev.com/07373421ccbda77a1a3882bd045fbf4ce1a707fa
Cr-Commit-Position: refs/heads/master@{#421202}

[Xi Han, 2016-09-26 19:36:06]

The CQ bit was checked by hanxi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 19:36:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xi Han, 2016-09-26 19:45:08]

hanxi@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[Xi Han, 2016-09-26 19:45:09]

Hi Peter, could you please take a look? Thanks!

[pkotwicz, 2016-09-26 20:23:11]

LGTM with nits

Can you change the CL title to something more descriptive. For instance: "Pass
WebAPK install source to AppBannerInfobarDelegateAndroid constructor"

https://codereview.chromium.org/2375503003/diff/20001/chrome/browser/android/...
File chrome/browser/android/banners/app_banner_infobar_delegate_android.h
(right):

https://codereview.chromium.org/2375503003/diff/20001/chrome/browser/android/...
chrome/browser/android/banners/app_banner_infobar_delegate_android.h:116: bool
AcceptWebApk(content::WebContents* web_contents);
Nit: New line

Whenever I add a function which has a comment, I always add a new line before
the comment and after the function

https://codereview.chromium.org/2375503003/diff/20001/chrome/browser/android/...
chrome/browser/android/banners/app_banner_infobar_delegate_android.h:155:
webapk::InstallSource install_source_;
Nit: |install_source_| -> |webapk_install_source_|

[Xi Han, 2016-09-26 20:24:51]

Description was changed from

==========
A follow up of "intruduce WebAPK install metrics".

This is a follow up CL for CL (https://codereview.chromium.org/2301263004).
The InstallSource is passed into the constructor of
AppBannerInfoBarDelegationAndroid, so we can call Accept() instead of
AcceptWebApk() when installing a WebAPK from add-to-homescreen menu.

BUG=626510
==========

to

==========
Pass WebAPK install source to AppBannerInfobarDelegateAndroid constructor.

This is a follow up CL for CL (https://codereview.chromium.org/2301263004).
The InstallSource is passed into the constructor of
AppBannerInfoBarDelegationAndroid, so we can call Accept() instead of
AcceptWebApk() when installing a WebAPK from add-to-homescreen menu.

BUG=626510
==========

[Xi Han, 2016-09-26 20:32:08]

Patchset #3 (id:40001) has been deleted

[Xi Han, 2016-09-26 20:33:30]

hanxi@chromium.org changed reviewers:
+ dominickn@chromium.org

[Xi Han, 2016-09-26 20:33:31]

Hi dominickn@: please take a look, thanks!

https://codereview.chromium.org/2375503003/diff/20001/chrome/browser/android/...
File chrome/browser/android/banners/app_banner_infobar_delegate_android.h
(right):

https://codereview.chromium.org/2375503003/diff/20001/chrome/browser/android/...
chrome/browser/android/banners/app_banner_infobar_delegate_android.h:116: bool
AcceptWebApk(content::WebContents* web_contents);
On 2016/09/26 20:23:10, pkotwicz wrote:
> Nit: New line
> 
> Whenever I add a function which has a comment, I always add a new line before
> the comment and after the function

Done.

https://codereview.chromium.org/2375503003/diff/20001/chrome/browser/android/...
chrome/browser/android/banners/app_banner_infobar_delegate_android.h:155:
webapk::InstallSource install_source_;
On 2016/09/26 20:23:10, pkotwicz wrote:
> Nit: |install_source_| -> |webapk_install_source_|

Done.

[dominickn, 2016-09-27 01:36:55]

lgtm % nit

https://codereview.chromium.org/2375503003/diff/60001/chrome/browser/android/...
File chrome/browser/android/banners/app_banner_infobar_delegate_android.h
(right):

https://codereview.chromium.org/2375503003/diff/60001/chrome/browser/android/...
chrome/browser/android/banners/app_banner_infobar_delegate_android.h:75: //
ConfirmInfoBarDelegate:
Does this method need to be public? If it's only being called from
AppBannerInfoBarDelegate::Create, then you should be able to keep it private
where it was originally.

[Xi Han, 2016-09-27 13:44:04]

https://codereview.chromium.org/2375503003/diff/60001/chrome/browser/android/...
File chrome/browser/android/banners/app_banner_infobar_delegate_android.h
(right):

https://codereview.chromium.org/2375503003/diff/60001/chrome/browser/android/...
chrome/browser/android/banners/app_banner_infobar_delegate_android.h:75: //
ConfirmInfoBarDelegate:
On 2016/09/27 01:36:55, dominickn wrote:
> Does this method need to be public? If it's only being called from
> AppBannerInfoBarDelegate::Create, then you should be able to keep it private
> where it was originally.

Well, it has to be public. The AppBannerInfoBarDelegateAndroid::Create() is a
static function, so it can only call public function of the
AppBannerInfoBarDelegateAndroid.

[Xi Han, 2016-09-27 13:44:11]

The CQ bit was checked by hanxi@chromium.org

[Xi Han, 2016-09-27 13:44:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/2375503003/#ps60001
(title: "pkotwicz@'s comments.")

[commit-bot: I haz the power, 2016-09-27 13:44:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 14:36:33]

Description was changed from

==========
Pass WebAPK install source to AppBannerInfobarDelegateAndroid constructor.

This is a follow up CL for CL (https://codereview.chromium.org/2301263004).
The InstallSource is passed into the constructor of
AppBannerInfoBarDelegationAndroid, so we can call Accept() instead of
AcceptWebApk() when installing a WebAPK from add-to-homescreen menu.

BUG=626510
==========

to

==========
Pass WebAPK install source to AppBannerInfobarDelegateAndroid constructor.

This is a follow up CL for CL (https://codereview.chromium.org/2301263004).
The InstallSource is passed into the constructor of
AppBannerInfoBarDelegationAndroid, so we can call Accept() instead of
AcceptWebApk() when installing a WebAPK from add-to-homescreen menu.

BUG=626510
==========

[commit-bot: I haz the power, 2016-09-27 14:36:34]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-27 14:39:47]

Description was changed from

==========
Pass WebAPK install source to AppBannerInfobarDelegateAndroid constructor.

This is a follow up CL for CL (https://codereview.chromium.org/2301263004).
The InstallSource is passed into the constructor of
AppBannerInfoBarDelegationAndroid, so we can call Accept() instead of
AcceptWebApk() when installing a WebAPK from add-to-homescreen menu.

BUG=626510
==========

to

==========
Pass WebAPK install source to AppBannerInfobarDelegateAndroid constructor.

This is a follow up CL for CL (https://codereview.chromium.org/2301263004).
The InstallSource is passed into the constructor of
AppBannerInfoBarDelegationAndroid, so we can call Accept() instead of
AcceptWebApk() when installing a WebAPK from add-to-homescreen menu.

BUG=626510

Committed: https://crrev.com/07373421ccbda77a1a3882bd045fbf4ce1a707fa
Cr-Commit-Position: refs/heads/master@{#421202}
==========

[commit-bot: I haz the power, 2016-09-27 14:39:48]

Patchset 3 (id:??) landed as
https://crrev.com/07373421ccbda77a1a3882bd045fbf4ce1a707fa
Cr-Commit-Position: refs/heads/master@{#421202}