Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2375493005: Enabled Pointer Events API in stable. (Closed)

Created:
4 years, 2 months ago by mustaq
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enabled Pointer Events API in stable. Intent to ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/UY1EfjaGF_E/OU7W_s3PAgAJ BUG=196799 Committed: https://crrev.com/902a3d6303dfbfd49a24173777afcb4b70234a17 Cr-Commit-Position: refs/heads/master@{#421811}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Matched content_features.cc state. #

Patch Set 3 : Fixed runtime_features.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -4 lines) Patch
M content/child/runtime_features.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_features.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 12 chunks +26 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 13 chunks +74 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (12 generated)
mustaq
ptal
4 years, 2 months ago (2016-09-27 18:28:41 UTC) #4
dtapuska
https://codereview.chromium.org/2375493005/diff/1/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/2375493005/diff/1/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in#newcode170 third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:170: PointerEvent status=stable I'd like https://cs.chromium.org/chromium/src/content/public/common/content_features.cc?q=content_feature&sq=package:chromium&l=119 adjusted to match Please ...
4 years, 2 months ago (2016-09-27 18:38:27 UTC) #5
Rick Byers
Please add a link to the intent to ship thread in the CL description. LGTM ...
4 years, 2 months ago (2016-09-27 21:11:14 UTC) #8
Rick Byers
Please add a link to the intent to ship thread in the CL description. LGTM ...
4 years, 2 months ago (2016-09-27 21:11:15 UTC) #9
mustaq
Seems with PointerEvent=stable, the feature is active no matter what the command-line (--disable-features=PointerEvent) or UI ...
4 years, 2 months ago (2016-09-28 15:58:12 UTC) #10
Rick Byers
On 2016/09/28 15:58:12, mustaq wrote: > Seems with PointerEvent=stable, the feature is active no matter ...
4 years, 2 months ago (2016-09-28 16:00:56 UTC) #11
mustaq
On 2016/09/28 16:00:56, Rick Byers wrote: > On 2016/09/28 15:58:12, mustaq wrote: > > Seems ...
4 years, 2 months ago (2016-09-28 16:22:51 UTC) #12
dtapuska
On 2016/09/28 16:22:51, mustaq wrote: > On 2016/09/28 16:00:56, Rick Byers wrote: > > On ...
4 years, 2 months ago (2016-09-28 16:40:31 UTC) #13
mustaq
On 2016/09/28 16:40:31, dtapuska wrote: > On 2016/09/28 16:22:51, mustaq wrote: > > On 2016/09/28 ...
4 years, 2 months ago (2016-09-28 17:35:27 UTC) #16
dtapuska
On 2016/09/28 17:35:27, mustaq wrote: > On 2016/09/28 16:40:31, dtapuska wrote: > > On 2016/09/28 ...
4 years, 2 months ago (2016-09-28 17:36:36 UTC) #17
mustaq
jochen@chromium.org: Please review changes in content/
4 years, 2 months ago (2016-09-28 17:52:29 UTC) #19
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-09-29 12:01:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375493005/40001
4 years, 2 months ago (2016-09-29 12:41:31 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-29 14:11:16 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 14:13:32 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/902a3d6303dfbfd49a24173777afcb4b70234a17
Cr-Commit-Position: refs/heads/master@{#421811}

Powered by Google App Engine
This is Rietveld 408576698