Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2414)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

Issue 2375493003: MD Settings: Fix rendering of popup menus inside iron-lists. (Closed)
Patch Set: Nit Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
index cad9521d8984766b0cac7b8073ad18a03f9124a5..9c65c235293b4be3ef858c9f8d0a43643783a8f2 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
@@ -6,17 +6,11 @@
* @fileoverview 'settings-search-engine-entry' is a component for showing a
* search engine with its name, domain and query URL.
*/
-(function() {
-/**
- * The max z index assigned to a <settings-search-engine-entry> so far. Used to
- * ensure that the popup menu is displayed correctly.
- * @type {number}
- */
-var maxZIndex = 0;
stevenjb 2016/09/26 22:52:00 Rebase?
dpapad 2016/09/26 23:04:32 Done.
-
Polymer({
is: 'settings-search-engine-entry',
+ behaviors: [settings.ListItemBehavior],
+
properties: {
/** @type {!SearchEngine} */
engine: Object,
@@ -76,11 +70,6 @@ Polymer({
},
/** @private */
- onDotsTap_: function() {
- this.style.zIndex = ++maxZIndex;
- },
-
- /** @private */
closePopupMenu_: function() {
this.$$('iron-dropdown').close();
},
@@ -95,4 +84,3 @@ Polymer({
return cr.icon.getFavicon(url || '');
},
});
-})();

Powered by Google App Engine
This is Rietveld 408576698