Move FilterOperation*.{cpp,h} to core/style/

Move FilterOperation*.{cpp,h} to core/style/

Move the FilterOperation(s) structures to core/style to make them a
"style type". This is in preparation for an improved mechanism for
signaling mutations to "reference" filters.

This is essentially a pure move, with only minor modifications to fix
some presubmit issues and to facilitate (fix) building.
(ASSERT -> DCHECK; PLATFORM_EXPORT -> CORE_EXPORT)

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7097b63c018b5debd6ac968525b36a826047c35c
Cr-Commit-Position: refs/heads/master@{#421796}

[fs, 2016-09-26 17:11:48]

Description was changed from

==========
Move FilterOperation*.{cpp,h} to core/style/

BUG=439970
==========

to

==========
Move FilterOperation*.{cpp,h} to core/style/

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-26 17:11:54]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 17:12:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 18:15:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 18:15:31]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[fs, 2016-09-27 08:21:15]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 08:21:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 09:57:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 09:57:29]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-27 10:24:47]

Description was changed from

==========
Move FilterOperation*.{cpp,h} to core/style/

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move FilterOperation*.{cpp,h} to core/style/

Move the FilterOperation(s) structures to core/style to make them a
"style type". This is in preparation for an improved mechanism for
signaling mutations to "reference" filters.

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-27 10:26:38]

Description was changed from

==========
Move FilterOperation*.{cpp,h} to core/style/

Move the FilterOperation(s) structures to core/style to make them a
"style type". This is in preparation for an improved mechanism for
signaling mutations to "reference" filters.

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move FilterOperation*.{cpp,h} to core/style/

Move the FilterOperation(s) structures to core/style to make them a
"style type". This is in preparation for an improved mechanism for
signaling mutations to "reference" filters.

This is essentially a pure move, with only minor modifications to fix
some presubmit issues and to facilitate (fix) building.
(ASSERT -> DCHECK; PLATFORM_EXPORT -> CORE_EXPORT)

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-27 10:28:10]

fs@opera.com changed reviewers:
+ chrishtr@chromium.org, senorblanco@chromium.org

[Stephen White, 2016-09-27 14:18:02]

LGTM

Nice!

[chromium-reviews, 2016-09-27 19:14:39]

driveby thought: I guess this makes it harder to merge blink and cc's
filter operations together, if that was something you want to do.

On Tue, Sep 27, 2016 at 7:18 AM, <senorblanco@chromium.org> wrote:

> LGTM
>
> Nice!
>
> https://codereview.chromium.org/2375453002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[blink-reviews, 2016-09-27 19:14:39]

driveby thought: I guess this makes it harder to merge blink and cc's
filter operations together, if that was something you want to do.

On Tue, Sep 27, 2016 at 7:18 AM, <senorblanco@chromium.org> wrote:

> LGTM
>
> Nice!
>
> https://codereview.chromium.org/2375453002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[fs, 2016-09-27 19:35:43]

On 2016/09/27 at 19:14:39, blink-reviews wrote:
> driveby thought: I guess this makes it harder to merge blink and cc's
> filter operations together, if that was something you want to do.

The way I see it these are better off as different levels of abstraction -
blink::FilterOperations being the representation for the style-system, while the
CC-type(s) primarily cater to the needs of the compositor animation system. (If
there was no need for CC to further manipulate the chain, Blink could construct
and pass a chain of SkImageFilters directly I believe.)

[Stephen White, 2016-09-27 21:11:51]

On 2016/09/27 19:35:43, fs wrote:
> On 2016/09/27 at 19:14:39, blink-reviews wrote:
> > driveby thought: I guess this makes it harder to merge blink and cc's
> > filter operations together, if that was something you want to do.
> 
> The way I see it these are better off as different levels of abstraction -
> blink::FilterOperations being the representation for the style-system, while
the
> CC-type(s) primarily cater to the needs of the compositor animation system.
(If
> there was no need for CC to further manipulate the chain, Blink could
construct
> and pass a chain of SkImageFilters directly I believe.)

Soo many filter hierarchies...

A long while back, I was attempting to get rid of cc::FilterOperations
altogether 
and move us to an all-SkImageFilter world, but shorthand filter animations were 
moved off-thread, which meant cc still need to know about the original
operations.

At some point, we could probably get rid of CompositorFilterOperations in favour
of 
cc::FilterOperations, though (assuming that isn't a layering violation).

[blink-reviews, 2016-09-27 22:01:45]

On Tue, Sep 27, 2016 at 2:11 PM, <senorblanco@chromium.org> wrote:

> On 2016/09/27 19:35:43, fs wrote:
> > On 2016/09/27 at 19:14:39, blink-reviews wrote:
> > > driveby thought: I guess this makes it harder to merge blink and cc's
> > > filter operations together, if that was something you want to do.
> >
> > The way I see it these are better off as different levels of abstraction
> -
> > blink::FilterOperations being the representation for the style-system,
> while
> the
> > CC-type(s) primarily cater to the needs of the compositor animation
> system.
> (If
> > there was no need for CC to further manipulate the chain, Blink could
> construct
> > and pass a chain of SkImageFilters directly I believe.)
>
> Soo many filter hierarchies...
>
> A long while back, I was attempting to get rid of cc::FilterOperations
> altogether
> and move us to an all-SkImageFilter world, but shorthand filter animations
> were
> moved off-thread, which meant cc still need to know about the original
> operations.
>
> At some point, we could probably get rid of CompositorFilterOperations in
> favour
> of
> cc::FilterOperations, though (assuming that isn't a layering violation).
>

it's not if they are used from platform/. cc things can't be used from core
tho, platform is supposed to provide higher level APIs to core around
things. At least atm.


>
> https://codereview.chromium.org/2375453002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-09-27 22:01:45]

On Tue, Sep 27, 2016 at 2:11 PM, <senorblanco@chromium.org> wrote:

> On 2016/09/27 19:35:43, fs wrote:
> > On 2016/09/27 at 19:14:39, blink-reviews wrote:
> > > driveby thought: I guess this makes it harder to merge blink and cc's
> > > filter operations together, if that was something you want to do.
> >
> > The way I see it these are better off as different levels of abstraction
> -
> > blink::FilterOperations being the representation for the style-system,
> while
> the
> > CC-type(s) primarily cater to the needs of the compositor animation
> system.
> (If
> > there was no need for CC to further manipulate the chain, Blink could
> construct
> > and pass a chain of SkImageFilters directly I believe.)
>
> Soo many filter hierarchies...
>
> A long while back, I was attempting to get rid of cc::FilterOperations
> altogether
> and move us to an all-SkImageFilter world, but shorthand filter animations
> were
> moved off-thread, which meant cc still need to know about the original
> operations.
>
> At some point, we could probably get rid of CompositorFilterOperations in
> favour
> of
> cc::FilterOperations, though (assuming that isn't a layering violation).
>

it's not if they are used from platform/. cc things can't be used from core
tho, platform is supposed to provide higher level APIs to core around
things. At least atm.


>
> https://codereview.chromium.org/2375453002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[fs, 2016-09-28 14:03:38]

On 2016/09/27 at 22:01:45, chromium-reviews wrote:
> On Tue, Sep 27, 2016 at 2:11 PM, <senorblanco@chromium.org> wrote:
> 
> > On 2016/09/27 19:35:43, fs wrote:
> > > On 2016/09/27 at 19:14:39, blink-reviews wrote:
> > > > driveby thought: I guess this makes it harder to merge blink and cc's
> > > > filter operations together, if that was something you want to do.
> > >
> > > The way I see it these are better off as different levels of abstraction
> > -
> > > blink::FilterOperations being the representation for the style-system,
> > while
> > the
> > > CC-type(s) primarily cater to the needs of the compositor animation
> > system.
> > (If
> > > there was no need for CC to further manipulate the chain, Blink could
> > construct
> > > and pass a chain of SkImageFilters directly I believe.)
> >
> > Soo many filter hierarchies...

Indeed...

> > A long while back, I was attempting to get rid of cc::FilterOperations
> > altogether
> > and move us to an all-SkImageFilter world, but shorthand filter animations
> > were
> > moved off-thread, which meant cc still need to know about the original
> > operations.
> >
> > At some point, we could probably get rid of CompositorFilterOperations in
> > favour
> > of
> > cc::FilterOperations, though (assuming that isn't a layering violation).
> >
> 
> it's not if they are used from platform/. cc things can't be used from core
> tho, platform is supposed to provide higher level APIs to core around
> things. At least atm.

In a similar vain I don't see why you'd want to impose the requirements of the
upper layers onto the lower layers (thinking about things like producing output
for getComputedStyle, and naturally the managing of element references - which
is what I'm working on ATM.)

[fs, 2016-09-29 09:10:54]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-09-29 09:11:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 10:46:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-29 10:47:50]

Description was changed from

==========
Move FilterOperation*.{cpp,h} to core/style/

Move the FilterOperation(s) structures to core/style to make them a
"style type". This is in preparation for an improved mechanism for
signaling mutations to "reference" filters.

This is essentially a pure move, with only minor modifications to fix
some presubmit issues and to facilitate (fix) building.
(ASSERT -> DCHECK; PLATFORM_EXPORT -> CORE_EXPORT)

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move FilterOperation*.{cpp,h} to core/style/

Move the FilterOperation(s) structures to core/style to make them a
"style type". This is in preparation for an improved mechanism for
signaling mutations to "reference" filters.

This is essentially a pure move, with only minor modifications to fix
some presubmit issues and to facilitate (fix) building.
(ASSERT -> DCHECK; PLATFORM_EXPORT -> CORE_EXPORT)

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7097b63c018b5debd6ac968525b36a826047c35c
Cr-Commit-Position: refs/heads/master@{#421796}
==========

[commit-bot: I haz the power, 2016-09-29 10:47:52]

Patchset 2 (id:??) landed as
https://crrev.com/7097b63c018b5debd6ac968525b36a826047c35c
Cr-Commit-Position: refs/heads/master@{#421796}