Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 23754026: Properly check for a zero-valued floating-point viewport argument (Closed)

Created:
7 years, 3 months ago by jdduke (slow)
Modified:
7 years, 2 months ago
CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, mkosiba (inactive)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Properly check for a zero-valued floating-point viewport argument Zero-valued viewport arguments are given special treatment under certain circumstances. Fix an issue where argument values less than 1 were incorrectly cast to zero, resulting in an improperly configured viewport. BUG=295886, 282130 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158197

Patch Set 1 #

Patch Set 2 : Unit test #

Patch Set 3 : Add test page #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M Source/core/dom/ViewportArguments.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 1 chunk +29 lines, -0 lines 0 comments Download
A Source/web/tests/data/viewport-nonzero-values.html View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jdduke (slow)
PTAL.
7 years, 3 months ago (2013-09-20 22:48:20 UTC) #1
jdduke (slow)
On 2013/09/20 22:48:20, jdduke wrote: > PTAL. I'll add some testing coverage to WebFrameTest assuming ...
7 years, 3 months ago (2013-09-21 02:19:30 UTC) #2
mnaganov (inactive)
LGTM Thanks for the fix, Jared! Sorry, I totally forgot that floats <1 are cast ...
7 years, 3 months ago (2013-09-23 09:26:08 UTC) #3
jdduke (slow)
abarth@: PTAL for owners. Thanks.
7 years, 2 months ago (2013-09-23 15:41:49 UTC) #4
abarth-chromium
lgtm
7 years, 2 months ago (2013-09-23 17:12:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/23754026/12001
7 years, 2 months ago (2013-09-23 17:12:58 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-09-23 18:38:20 UTC) #7
Message was sent while issue was closed.
Change committed as 158197

Powered by Google App Engine
This is Rietveld 408576698