Issue 23754005: Have CharacterData constructor take a Document reference in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23754005: Have CharacterData constructor take a Document reference in argument (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, dglazkov

CC:
blink-reviews, dglazkov+blink, nessy, eae+blinkwatch, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have CharacterData constructor take a Document reference in argument Have CharacterData constructor take a Document reference in argument instead of a pointer as it can never be NULL. CharacterData subclasses (Comment, Text), have been updated to use references as well. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157373

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -25 lines)			Patch
M	Source/core/dom/CharacterData.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Comment.h	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	Source/core/dom/Comment.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/ProcessingInstruction.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/ProcessingInstruction.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/Text.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/parser/HTMLConstructionSite.cpp	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	Source/core/html/track/WebVTTParser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/parser/XMLDocumentParser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23754005/1

7 years, 3 months ago (2013-09-06 14:43:50 UTC) #3

Message was sent while issue was closed.

Change committed as 157373

Expand Messages | Collapse Messages