Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: src/hydrogen.cc

Issue 23754002: Fix assert triggered by constant folding. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address review Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1519 matching lines...) Expand 10 before | Expand all | Expand 10 after
1530 } 1530 }
1531 1531
1532 1532
1533 HLoadNamedField* HGraphBuilder::AddLoadFixedArrayLength(HValue* object) { 1533 HLoadNamedField* HGraphBuilder::AddLoadFixedArrayLength(HValue* object) {
1534 return Add<HLoadNamedField>(object, 1534 return Add<HLoadNamedField>(object,
1535 HObjectAccess::ForFixedArrayLength()); 1535 HObjectAccess::ForFixedArrayLength());
1536 } 1536 }
1537 1537
1538 1538
1539 HValue* HGraphBuilder::BuildNewElementsCapacity(HValue* old_capacity) { 1539 HValue* HGraphBuilder::BuildNewElementsCapacity(HValue* old_capacity) {
1540 HValue* half_old_capacity = Add<HShr>(old_capacity, graph_->GetConstant1()); 1540 HValue* half_old_capacity = AddUncasted<HShr>(old_capacity,
1541 graph_->GetConstant1());
1541 1542
1542 HValue* new_capacity = Add<HAdd>(half_old_capacity, old_capacity); 1543 HValue* new_capacity = AddUncasted<HAdd>(half_old_capacity, old_capacity);
1543 new_capacity->ClearFlag(HValue::kCanOverflow); 1544 new_capacity->ClearFlag(HValue::kCanOverflow);
1544 1545
1545 HValue* min_growth = Add<HConstant>(16); 1546 HValue* min_growth = Add<HConstant>(16);
1546 1547
1547 new_capacity = Add<HAdd>(new_capacity, min_growth); 1548 new_capacity = AddUncasted<HAdd>(new_capacity, min_growth);
1548 new_capacity->ClearFlag(HValue::kCanOverflow); 1549 new_capacity->ClearFlag(HValue::kCanOverflow);
1549 1550
1550 return new_capacity; 1551 return new_capacity;
1551 } 1552 }
1552 1553
1553 1554
1554 void HGraphBuilder::BuildNewSpaceArrayCheck(HValue* length, ElementsKind kind) { 1555 void HGraphBuilder::BuildNewSpaceArrayCheck(HValue* length, ElementsKind kind) {
1555 Heap* heap = isolate()->heap(); 1556 Heap* heap = isolate()->heap();
1556 int element_size = IsFastDoubleElementsKind(kind) ? kDoubleSize 1557 int element_size = IsFastDoubleElementsKind(kind) ? kDoubleSize
1557 : kPointerSize; 1558 : kPointerSize;
(...skipping 8325 matching lines...) Expand 10 before | Expand all | Expand 10 after
9883 if (ShouldProduceTraceOutput()) { 9884 if (ShouldProduceTraceOutput()) {
9884 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9885 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9885 } 9886 }
9886 9887
9887 #ifdef DEBUG 9888 #ifdef DEBUG
9888 graph_->Verify(false); // No full verify. 9889 graph_->Verify(false); // No full verify.
9889 #endif 9890 #endif
9890 } 9891 }
9891 9892
9892 } } // namespace v8::internal 9893 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698