Don't use actual dependency walker in pub summaries.

Don't use actual dependency walker in pub summaries.

We already pre-check transitive dependencies, so we know which nodes
can be linked, and can use just a single link() invocation.

The code is slightly worse, because I stuffed several more operations
into getLinkedBundles(), but either this, or passing several parameters
around :-(

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/36d737008f6ce7d9d9d0dcf5bb58fe48e5633a72

[Brian Wilkerson, 2016-09-29 16:34:22]

> The code is slightly worse, because I stuffed several more operations
into getLinkedBundles(), but either this, or passing several parameters
around.

Or creating an object to hold all the information you need.

Either way, lgtm.

[scheglov, 2016-09-29 17:30:40]

Description was changed from

==========
Don't use actual dependency walker in pub summaries.

We already pre-check transitive dependencies, so we know which nodes
can be linked, and can use just a single link() invocation.

The code is slightly worse, because I stuffed several more operations
into getLinkedBundles(), but either this, or passing several parameters
around :-(

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Don't use actual dependency walker in pub summaries.

We already pre-check transitive dependencies, so we know which nodes
can be linked, and can use just a single link() invocation.

The code is slightly worse, because I stuffed several more operations
into getLinkedBundles(), but either this, or passing several parameters
around :-(

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/36d737008f6ce7d9d9d0dcf5bb58fe48e5633a72
==========

[scheglov, 2016-09-29 17:30:41]

Committed patchset #2 (id:20001) manually as
36d737008f6ce7d9d9d0dcf5bb58fe48e5633a72 (presubmit successful).