CSS Properties and Values API: Reject CSS-wide keywords in syntax string

CSS Properties and Values API: Reject CSS-wide keywords in syntax string

This patch disallows using css-wide keywords in the syntax string for
properties registration. Currently they're accepted as part of the
<custom-ident> production, but css-wide keywords are not valid for this
production.

https://drafts.css-houdini.org/css-properties-values-api/#supported-syntax-strings
https://drafts.csswg.org/css-values-4/#identifier-value
https://drafts.csswg.org/css-cascade-4/#defaulting-keywords

BUG=641877
Committed: https://crrev.com/9b90d79448d2446c69a10240ccaf81b6a15f8be5
Cr-Commit-Position: refs/heads/master@{#422052}

[Timothy Loh, 2016-09-30 03:54:51]

Description was changed from

==========
Reject CSS-wide keywords for initialValue of registered properties of '*' type

This patch disallows using css-wide keywords for the initial value of
properties registered with the token stream type (i.e. '*'). This is
the values 'initial', 'inherit', 'unset', 'default', and 'revert', but
'revert' is not yet supported so we don't reject it yet.

BUG=641877
==========

to

==========
CSS Properties and Values API: Reject CSS-wide keywords in syntax string

This patch disallows using css-wide keywords in the syntax string for
properties registration. Currently they're accepted as part of the
<custom-ident> production, but css-wide keywords are not valid for this
production.

BUG=641877
==========

[Timothy Loh, 2016-09-30 03:55:38]

Patchset #1 (id:1) has been deleted

[Timothy Loh, 2016-09-30 03:56:15]

Description was changed from

==========
CSS Properties and Values API: Reject CSS-wide keywords in syntax string

This patch disallows using css-wide keywords in the syntax string for
properties registration. Currently they're accepted as part of the
<custom-ident> production, but css-wide keywords are not valid for this
production.

BUG=641877
==========

to

==========
CSS Properties and Values API: Reject CSS-wide keywords in syntax string

This patch disallows using css-wide keywords in the syntax string for
properties registration. Currently they're accepted as part of the
<custom-ident> production, but css-wide keywords are not valid for this
production.

https://drafts.css-houdini.org/css-properties-values-api/#supported-syntax-st...
https://drafts.csswg.org/css-values-4/#identifier-value
https://drafts.csswg.org/css-cascade-4/#defaulting-keywords

BUG=641877
==========

[Timothy Loh, 2016-09-30 03:56:15]

timloh@chromium.org changed reviewers:
+ nainar@chromium.org

[Timothy Loh, 2016-09-30 03:56:55]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 03:57:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2016-09-30 03:59:10]

I think something in the expected.txt file makes it not show up in Rietveld, but
you can see it from the raw diffs
(https://codereview.chromium.org/download/issue2375353004_20001.diff)

[nainar, 2016-09-30 04:09:55]

lgtm

[Timothy Loh, 2016-09-30 04:18:00]

The CQ bit was unchecked by timloh@chromium.org

[Timothy Loh, 2016-09-30 04:18:00]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2016-09-30 04:18:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 07:17:13]

Description was changed from

==========
CSS Properties and Values API: Reject CSS-wide keywords in syntax string

This patch disallows using css-wide keywords in the syntax string for
properties registration. Currently they're accepted as part of the
<custom-ident> production, but css-wide keywords are not valid for this
production.

https://drafts.css-houdini.org/css-properties-values-api/#supported-syntax-st...
https://drafts.csswg.org/css-values-4/#identifier-value
https://drafts.csswg.org/css-cascade-4/#defaulting-keywords

BUG=641877
==========

to

==========
CSS Properties and Values API: Reject CSS-wide keywords in syntax string

This patch disallows using css-wide keywords in the syntax string for
properties registration. Currently they're accepted as part of the
<custom-ident> production, but css-wide keywords are not valid for this
production.

https://drafts.css-houdini.org/css-properties-values-api/#supported-syntax-st...
https://drafts.csswg.org/css-values-4/#identifier-value
https://drafts.csswg.org/css-cascade-4/#defaulting-keywords

BUG=641877
==========

[commit-bot: I haz the power, 2016-09-30 07:17:14]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-09-30 07:19:41]

Description was changed from

==========
CSS Properties and Values API: Reject CSS-wide keywords in syntax string

This patch disallows using css-wide keywords in the syntax string for
properties registration. Currently they're accepted as part of the
<custom-ident> production, but css-wide keywords are not valid for this
production.

https://drafts.css-houdini.org/css-properties-values-api/#supported-syntax-st...
https://drafts.csswg.org/css-values-4/#identifier-value
https://drafts.csswg.org/css-cascade-4/#defaulting-keywords

BUG=641877
==========

to

==========
CSS Properties and Values API: Reject CSS-wide keywords in syntax string

This patch disallows using css-wide keywords in the syntax string for
properties registration. Currently they're accepted as part of the
<custom-ident> production, but css-wide keywords are not valid for this
production.

https://drafts.css-houdini.org/css-properties-values-api/#supported-syntax-st...
https://drafts.csswg.org/css-values-4/#identifier-value
https://drafts.csswg.org/css-cascade-4/#defaulting-keywords

BUG=641877

Committed: https://crrev.com/9b90d79448d2446c69a10240ccaf81b6a15f8be5
Cr-Commit-Position: refs/heads/master@{#422052}
==========

[commit-bot: I haz the power, 2016-09-30 07:19:42]

Patchset 1 (id:??) landed as
https://crrev.com/9b90d79448d2446c69a10240ccaf81b6a15f8be5
Cr-Commit-Position: refs/heads/master@{#422052}