core/fpdfapi/fpdf_parser/cpdf_object.cpp - Issue 2375343004: Assert that only 0-numbered objects are Released()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_object.cpp

Issue 2375343004: Assert that only 0-numbered objects are Released() (Closed)

Patch Set: brute-force delete unowned numbered object in one place Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_object.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_object.cpp b/core/fpdfapi/fpdf_parser/cpdf_object.cpp

index ba7490a13f7aa1f66976fa70e80565e6f6bb823a..d74003112fe3fb94ec650ae589e085769bd58b5e 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_object.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_object.cpp

@@ -38,9 +38,7 @@ CPDF_Object* CPDF_Object::CloneNonCyclic(

}

void CPDF_Object::Release() {

- if (m_ObjNum)

- return;

+ CHECK(!m_ObjNum);

Lei Zhang 2016/09/30 21:44:52 So should we also CHECK(m_ObjNum != kInvalidObjNum

Tom Sepez 2016/09/30 22:21:37 That's implied by the current check.

Lei Zhang 2016/09/30 22:36:04 It is? CHECK(m_ObjNum != 0); CHECK(m_ObjNum != 0x

delete this;

}