core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp - Issue 2375343004: Assert that only 0-numbered objects are Released()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp

Issue 2375343004: Assert that only 0-numbered objects are Released() (Closed)

Patch Set: Add unowned ptr to stream Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp b/core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp

index 5696fc0c8d7b874aefaf0637eb08843fbc2dccf0..eb40de7d495bea2ea7951608e91896cf0bfd9ab8 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp

@@ -30,7 +30,7 @@ CPDF_Dictionary::~CPDF_Dictionary() {

// in case of cyclic references.

m_ObjNum = kInvalidObjNum;

for (const auto& it : m_Map) {

- if (it.second)

+ if (it.second && it.second->GetObjNum() != kInvalidObjNum)

it.second->Release();

}