Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 237533015: ChromeOS: Keep app list centered when the display rotates by 90 degrees. (Closed)

Created:
6 years, 8 months ago by Matt Giuca
Modified:
6 years, 8 months ago
Reviewers:
xiyuan, James Cook
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, kalyank, sadrul, ben+ash_chromium.org, tfarina
Visibility:
Public.

Description

ChromeOS: Keep app list centered when the display rotates by 90 degrees. Only relevant for the --enable-experimental-app-list-position flag. AppListView now has a mode where it automatically keeps the bubble centered on the screen's primary display, rather than a fixed position. BUG=363928 TEST=Run with --enable-experimental-app-list-position. Open the app list, press Ctrl+Shift+F3 to rotate. App list should remain centered. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266176

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Abstract GetCenterPoint for code re-use. #

Patch Set 4 : Formatting. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M ash/wm/app_list_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/views/app_list_view.h View 1 2 4 chunks +21 lines, -0 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 2 3 6 chunks +27 lines, -1 line 1 comment Download

Messages

Total messages: 10 (0 generated)
Matt Giuca
jamescook: ash/wm/app_list_controller.cc xiyuan: ui/app_list/views/app_list_view.* Thanks! https://codereview.chromium.org/237533015/diff/100001/ui/app_list/views/app_list_view.cc File ui/app_list/views/app_list_view.cc (right): https://codereview.chromium.org/237533015/diff/100001/ui/app_list/views/app_list_view.cc#newcode360 ui/app_list/views/app_list_view.cc:360: gfx::Point AppListView::GetCenterPoint() { Note: ...
6 years, 8 months ago (2014-04-24 10:03:19 UTC) #1
xiyuan
lgtm
6 years, 8 months ago (2014-04-24 16:33:40 UTC) #2
James Cook
lgtm
6 years, 8 months ago (2014-04-24 17:18:18 UTC) #3
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 8 months ago (2014-04-25 01:50:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/237533015/100001
6 years, 8 months ago (2014-04-25 02:03:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 03:10:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 03:10:18 UTC) #7
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 8 months ago (2014-04-25 03:45:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/237533015/100001
6 years, 8 months ago (2014-04-25 03:45:38 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 09:27:52 UTC) #10
Message was sent while issue was closed.
Change committed as 266176

Powered by Google App Engine
This is Rietveld 408576698