Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: chrome/browser/guestview/adview/adview_guest.cc

Issue 237533008: Refactor GuestView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes are made. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guestview/adview/adview_guest.cc
diff --git a/chrome/browser/guestview/adview/adview_guest.cc b/chrome/browser/guestview/adview/adview_guest.cc
index 6b0de6fbca74d5e556d2d2ccca5982b2566817c3..e2524f60feb147de6b668c4a71a3b73208abe621 100644
--- a/chrome/browser/guestview/adview/adview_guest.cc
+++ b/chrome/browser/guestview/adview/adview_guest.cc
@@ -14,30 +14,12 @@ using content::WebContents;
AdViewGuest::AdViewGuest(WebContents* guest_web_contents,
const std::string& extension_id)
- : GuestView(guest_web_contents, extension_id),
+ : GuestView<AdViewGuest>(guest_web_contents, extension_id),
WebContentsObserver(guest_web_contents) {
}
// static
-AdViewGuest* AdViewGuest::From(int embedder_process_id,
- int guest_instance_id) {
- GuestView* guest = GuestView::From(embedder_process_id, guest_instance_id);
- if (!guest)
- return NULL;
- return guest->AsAdView();
-}
-
-GuestView::Type AdViewGuest::GetViewType() const {
- return GuestView::ADVIEW;
-}
-
-WebViewGuest* AdViewGuest::AsWebView() {
- return NULL;
-}
-
-AdViewGuest* AdViewGuest::AsAdView() {
- return this;
-}
+const std::string& AdViewGuest::Type = "adview";
AdViewGuest::~AdViewGuest() {
}
@@ -52,7 +34,8 @@ void AdViewGuest::DidCommitProvisionalLoadForFrame(
scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
args->SetString(guestview::kUrl, url.spec());
args->SetBoolean(guestview::kIsTopLevel, is_main_frame);
- DispatchEvent(new GuestView::Event(adview::kEventLoadCommit, args.Pass()));
+ DispatchEvent(
+ new GuestViewBase::Event(adview::kEventLoadCommit, args.Pass()));
}
void AdViewGuest::DidFailProvisionalLoad(
@@ -71,5 +54,5 @@ void AdViewGuest::DidFailProvisionalLoad(
args->SetBoolean(guestview::kIsTopLevel, is_main_frame);
args->SetString(guestview::kUrl, validated_url.spec());
args->SetString(guestview::kReason, error_type);
- DispatchEvent(new GuestView::Event(adview::kEventLoadAbort, args.Pass()));
+ DispatchEvent(new GuestViewBase::Event(adview::kEventLoadAbort, args.Pass()));
}

Powered by Google App Engine
This is Rietveld 408576698