Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1933)

Unified Diff: chrome/browser/guestview/adview/adview_guest.h

Issue 237533008: Refactor GuestView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Introduce template class GuestView. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guestview/adview/adview_guest.h
diff --git a/chrome/browser/guestview/adview/adview_guest.h b/chrome/browser/guestview/adview/adview_guest.h
index aaefe00e3644e169025c63f031e977dd3cdd695f..2d0343df5462d639a691021415f9b02b475f3ab3 100644
--- a/chrome/browser/guestview/adview/adview_guest.h
+++ b/chrome/browser/guestview/adview/adview_guest.h
@@ -16,18 +16,13 @@
// a particular embedder WebContents, we call this "attachment".
// TODO(fsamuel): There might be an opportunity here to refactor and reuse code
// between AdViewGuest and WebViewGuest.
-class AdViewGuest : public GuestView,
+class AdViewGuest : public GuestView<AdViewGuest>,
public content::WebContentsObserver {
public:
AdViewGuest(content::WebContents* guest_web_contents,
const std::string& extension_id);
- static AdViewGuest* From(int embedder_process_id, int instance_id);
-
- // GuestView implementation.
- virtual GuestView::Type GetViewType() const OVERRIDE;
- virtual WebViewGuest* AsWebView() OVERRIDE;
- virtual AdViewGuest* AsAdView() OVERRIDE;
+ static const std::string& Type;
private:
virtual ~AdViewGuest();

Powered by Google App Engine
This is Rietveld 408576698