Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6372)

Unified Diff: chrome/browser/guestview/guestview.cc

Issue 237533008: Refactor GuestView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guestview/guestview.cc
diff --git a/chrome/browser/guestview/guestview.cc b/chrome/browser/guestview/guestview.cc
index cb6444d6409d279b0cc85f43a34457ce11e6c61e..d3e9f928e45082e5b12b385ff06dae4a418a1185 100644
--- a/chrome/browser/guestview/guestview.cc
+++ b/chrome/browser/guestview/guestview.cc
@@ -168,14 +168,6 @@ GuestView::Type GuestView::GetViewType() const {
return GuestView::UNKNOWN;
}
-WebViewGuest* GuestView::AsWebView() {
- return NULL;
-}
-
-AdViewGuest* GuestView::AsAdView() {
- return NULL;
-}
-
GuestView::~GuestView() {
std::pair<int, int> key(embedder_render_process_id_, guest_instance_id_);
embedder_guestview_map.Get().erase(key);
@@ -189,8 +181,10 @@ GuestView::~GuestView() {
}
void GuestView::DispatchEvent(Event* event) {
- if (!in_extension())
- return;
+ if (!in_extension()) {
+ delete event;
+ return;
+ }
if (!attached()) {
pending_events_.push(event);

Powered by Google App Engine
This is Rietveld 408576698