Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Unified Diff: chrome/browser/guestview/adview/adview_guest.cc

Issue 237533008: Refactor GuestView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guestview/adview/adview_guest.cc
diff --git a/chrome/browser/guestview/adview/adview_guest.cc b/chrome/browser/guestview/adview/adview_guest.cc
index 6b0de6fbca74d5e556d2d2ccca5982b2566817c3..3c2cfc89084f35618d46f08c628be84a0e6f587b 100644
--- a/chrome/browser/guestview/adview/adview_guest.cc
+++ b/chrome/browser/guestview/adview/adview_guest.cc
@@ -24,20 +24,13 @@ AdViewGuest* AdViewGuest::From(int embedder_process_id,
GuestView* guest = GuestView::From(embedder_process_id, guest_instance_id);
if (!guest)
return NULL;
- return guest->AsAdView();
+ return guest->As<AdViewGuest>();
}
-GuestView::Type AdViewGuest::GetViewType() const {
- return GuestView::ADVIEW;
-}
-
-WebViewGuest* AdViewGuest::AsWebView() {
- return NULL;
-}
+// static
+GuestView::Type AdViewGuest::Type() { return GuestView::ADVIEW; }
-AdViewGuest* AdViewGuest::AsAdView() {
- return this;
-}
+GuestView::Type AdViewGuest::GetViewType() const { return Type(); }
AdViewGuest::~AdViewGuest() {
}

Powered by Google App Engine
This is Rietveld 408576698