chrome/browser/chrome_content_browser_client.cc - Issue 237533008: Refactor GuestView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 237533008: Refactor GuestView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index d0ed882ecb652a9a62a4789c3e880ff8bdc3f9d3..7052a0e9d2c9cb5b659230b1b22fcde8b984e5d8 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -838,7 +838,8 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(

/// TODO(fsamuel): In the future, certain types of GuestViews won't require

// extension bindings. At that point, we should clear |extension_id| instead

// of exiting early.

- if (!service->GetExtensionById(extension_id, false) &&

+ if (!extension_id.empty() &&

+ !service->GetExtensionById(extension_id, false) &&

!CommandLine::ForCurrentProcess()->HasSwitch(

switches::kEnableBrowserPluginForAllViewTypes)) {

NOTREACHED();