Index: lib/Bitcode/NaCl/Reader/NaClBitcodeHeader.cpp |
diff --git a/lib/Bitcode/NaCl/Reader/NaClBitcodeHeader.cpp b/lib/Bitcode/NaCl/Reader/NaClBitcodeHeader.cpp |
index 37b79ad3d8dc6338e31963ba806a31a469614a81..7cb6474caaeca2ffcb196a8317d240bc610f9175 100644 |
--- a/lib/Bitcode/NaCl/Reader/NaClBitcodeHeader.cpp |
+++ b/lib/Bitcode/NaCl/Reader/NaClBitcodeHeader.cpp |
@@ -10,6 +10,7 @@ |
#include "llvm/Bitcode/NaCl/NaClBitcodeHeader.h" |
#include "llvm/Bitcode/NaCl/NaClReaderWriter.h" |
+#include "llvm/Bitcode/ReaderWriter.h" |
#include "llvm/Support/ErrorHandling.h" |
#include "llvm/Support/Format.h" |
#include "llvm/Support/raw_ostream.h" |
@@ -118,7 +119,7 @@ std::string NaClBitcodeHeaderField::Contents() const { |
ss << "]"; |
break; |
default: |
- report_fatal_error("PNaCL bitcode file contains unknown field type"); |
+ report_fatal_error("PNaCl bitcode file contains unknown field type"); |
} |
return ss.str(); |
} |
@@ -140,8 +141,14 @@ bool NaClBitcodeHeader::ReadPrefix(const unsigned char *BufPtr, |
const unsigned char *BufEnd, |
unsigned &NumFields, unsigned &NumBytes) { |
// Must contain PEXE. |
- if (!isNaClBitcode(BufPtr, BufEnd)) |
+ if (!isNaClBitcode(BufPtr, BufEnd)) { |
+ UnsupportedMessage = "Invalid PNaCl bitcode header"; |
+ if (isBitcode(BufPtr, BufEnd)) { |
+ UnsupportedMessage += " (to run in Chrome, bitcode files must be " |
+ "finalized using pnacl-finalize"; |
jvoung (off chromium)
2013/09/10 20:39:56
add an end parenthesis to match the beginning "(to
Derek Schuff
2013/09/13 19:53:36
Done.
|
+ } |
return true; |
+ } |
BufPtr += WordSize; |
// Read #Fields and number of bytes needed for the header. |