Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2375293002: Set NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree flags on Node (Closed)
Patch Set: Add ability to clear dirty bits and relevant call sites Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.h ('k') | third_party/WebKit/Source/core/dom/Text.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Node.cpp
diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp
index a22173fd57d4a64eb69c6c2349f24d5ca289a1a9..40a09a43e28784060dc5dcbc07c8deba9b4b3c98 100644
--- a/third_party/WebKit/Source/core/dom/Node.cpp
+++ b/third_party/WebKit/Source/core/dom/Node.cpp
@@ -692,9 +692,20 @@ void Node::markAncestorsWithChildNeedsStyleRecalc() {
for (ContainerNode* p = parentOrShadowHostNode();
p && !p->childNeedsStyleRecalc(); p = p->parentOrShadowHostNode())
p->setChildNeedsStyleRecalc();
+ // TODO(nainar): Move this to Node::markAncestorsWithChildNeedsReattachLayoutTree()
document().scheduleLayoutTreeUpdateIfNeeded();
}
+void Node::markAncestorsWithChildNeedsReattachLayoutTree() {
+ for (ContainerNode* p = parentOrShadowHostNode();
+ p && !p->childNeedsReattachLayoutTree(); p = p->parentOrShadowHostNode())
+ p->setChildNeedsReattachLayoutTree();
+}
+void Node::setNeedsReattachLayoutTree() {
+ setFlag(NeedsReattachLayoutTree);
+ markAncestorsWithChildNeedsReattachLayoutTree();
+}
+
void Node::setNeedsStyleRecalc(StyleChangeType changeType,
const StyleChangeReasonForTracing& reason) {
DCHECK(changeType != NoStyleChange);
@@ -886,6 +897,7 @@ void Node::attachLayoutTree(const AttachContext&) {
(layoutObject()->parent() || layoutObject()->isLayoutView())));
clearNeedsStyleRecalc();
+ clearNeedsReattachLayoutTree();
if (AXObjectCache* cache = document().axObjectCache())
cache->updateCacheAfterNodeIsAttached(this);
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.h ('k') | third_party/WebKit/Source/core/dom/Text.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698