Set NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree flags on Node

third_party/WebKit/Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 674 matching lines @@
 
 inline void Node::setStyleChange(StyleChangeType changeType)
 {
     m_nodeFlags = (m_nodeFlags & ~StyleChangeMask) | changeType;
 }
 
 void Node::markAncestorsWithChildNeedsStyleRecalc()
 {
     for (ContainerNode* p = parentOrShadowHostNode(); p && !p->childNeedsStyleRecalc(); p = p->parentOrShadowHostNode())
         p->setChildNeedsStyleRecalc();
+    // TODO(nainar): Move this to Node::markAncestorsWithChildNeedsReattachLayoutTree()
     document().scheduleLayoutTreeUpdateIfNeeded();
 }
 
+void Node::markNodeAndAncestorsWithChildNeedsReattachLayoutTree()

[Bugs Nash, 2016/09/29 03:15:24]

This name implies that you're marking the current node with ChildNeedsReattach.
I actually think this logic would be better moved to the
setNeedsReattachLayoutTree method, as marking your ancestors with
ChildNeedsReattach comes hand in hand with marking yourself needing reattach.

[nainar, 2016/09/29 04:05:15]

Done.

+{
+    setNeedsReattachLayoutTree();
+    for (ContainerNode* p = parentOrShadowHostNode(); p && !p->childNeedsReattachLayoutTree(); p = p->parentOrShadowHostNode())
+        p->setChildNeedsReattachLayoutTree();
+}
+
+
 void Node::setNeedsStyleRecalc(StyleChangeType changeType, const StyleChangeReasonForTracing& reason)
 {
     DCHECK(changeType != NoStyleChange);
     if (!inActiveDocument())
         return;
 
     TRACE_EVENT_INSTANT1(
         TRACE_DISABLED_BY_DEFAULT("devtools.timeline.invalidationTracking"),
         "StyleRecalcInvalidationTracking",
         TRACE_EVENT_SCOPE_THREAD,
@@ skipping 1702 matching lines @@
     if (node) {
         std::stringstream stream;
         node->printNodePathTo(stream);
         LOG(INFO) << stream.str();
     } else {
         LOG(INFO) << "Cannot showNodePath for <null>";
     }
 }
 
 #endif