Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2375293002: Set NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree flags on Node (Closed)
Patch Set: Add comment back Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1811 matching lines...) Expand 10 before | Expand all | Expand 10 after
1822 1822
1823 StyleRecalcChange localChange = ComputedStyle::stylePropagationDiff(oldStyle .get(), newStyle.get()); 1823 StyleRecalcChange localChange = ComputedStyle::stylePropagationDiff(oldStyle .get(), newStyle.get());
1824 if (localChange == NoChange) { 1824 if (localChange == NoChange) {
1825 INCREMENT_STYLE_STATS_COUNTER(document().styleEngine(), stylesUnchanged, 1); 1825 INCREMENT_STYLE_STATS_COUNTER(document().styleEngine(), stylesUnchanged, 1);
1826 } else { 1826 } else {
1827 INCREMENT_STYLE_STATS_COUNTER(document().styleEngine(), stylesChanged, 1 ); 1827 INCREMENT_STYLE_STATS_COUNTER(document().styleEngine(), stylesChanged, 1 );
1828 } 1828 }
1829 1829
1830 if (localChange == Reattach) { 1830 if (localChange == Reattach) {
1831 // TODO(nainar): Remove the style parameter being passed into buildLayou tTree(). 1831 // TODO(nainar): Remove the style parameter being passed into buildLayou tTree().
1832 // ComputedStyle will now be stored on Node and accessed in buildLayoutT ree() 1832 // ComputedStyle will now be stored on Node and accessed in buildLayoutT ree()
Bugs Nash 2016/09/29 03:15:24 This comment needs to be updated to reflect the ne
nainar 2016/09/29 04:05:15 Done.
1833 // using mutableComputedStyle(). 1833 // using mutableComputedStyle().
1834 markNodeAndAncestorsWithChildNeedsReattachLayoutTree();
1834 return buildLayoutTree(*newStyle); 1835 return buildLayoutTree(*newStyle);
1835 } 1836 }
1836 1837
1837 DCHECK(oldStyle); 1838 DCHECK(oldStyle);
1838 1839
1839 if (localChange != NoChange) 1840 if (localChange != NoChange)
1840 updateCallbackSelectors(oldStyle.get(), newStyle.get()); 1841 updateCallbackSelectors(oldStyle.get(), newStyle.get());
1841 1842
1842 if (LayoutObject* layoutObject = this->layoutObject()) { 1843 if (LayoutObject* layoutObject = this->layoutObject()) {
1843 if (localChange != NoChange || pseudoStyleCacheIsInvalid(oldStyle.get(), newStyle.get()) || svgFilterNeedsLayerUpdate()) { 1844 if (localChange != NoChange || pseudoStyleCacheIsInvalid(oldStyle.get(), newStyle.get()) || svgFilterNeedsLayerUpdate()) {
(...skipping 1985 matching lines...) Expand 10 before | Expand all | Expand 10 after
3829 3830
3830 DEFINE_TRACE_WRAPPERS(Element) 3831 DEFINE_TRACE_WRAPPERS(Element)
3831 { 3832 {
3832 if (hasRareData()) { 3833 if (hasRareData()) {
3833 visitor->traceWrappers(elementRareData()); 3834 visitor->traceWrappers(elementRareData());
3834 } 3835 }
3835 ContainerNode::traceWrappers(visitor); 3836 ContainerNode::traceWrappers(visitor);
3836 } 3837 }
3837 3838
3838 } // namespace blink 3839 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Node.h » ('j') | third_party/WebKit/Source/core/dom/Node.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698