Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Side by Side Diff: content/browser/tracing/BUILD.gn

Issue 2375283004: Optionally compute grit inputs precisely. (Closed)
Patch Set: Remove implicit resource ids Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/devtools/BUILD.gn ('k') | third_party/google_input_tools/closure.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//tools/grit/grit_rule.gni") 5 import("//tools/grit/grit_rule.gni")
6 6
7 # generate_about_tracing puts its files in this directory 7 # generate_about_tracing puts its files in this directory
8 tracing_gen_dir = "$root_gen_dir/content/browser/tracing" 8 tracing_gen_dir = "$root_gen_dir/content/browser/tracing"
9 9
10 # The script just writes filename with no dirs to the .grd, so we always need 10 # The script just writes filename with no dirs to the .grd, so we always need
(...skipping 18 matching lines...) Expand all
29 rebase_path(tracing_grd, root_build_dir), 29 rebase_path(tracing_grd, root_build_dir),
30 ] 30 ]
31 31
32 deps = [ 32 deps = [
33 "//third_party/catapult/tracing:generate_about_tracing", 33 "//third_party/catapult/tracing:generate_about_tracing",
34 ] 34 ]
35 } 35 }
36 36
37 grit("resources") { 37 grit("resources") {
38 source = tracing_grd 38 source = tracing_grd
39 source_is_generated = true
40
39 outputs = [ 41 outputs = [
40 "grit/tracing_resources.h", 42 "grit/tracing_resources.h",
41 "tracing_resources.pak", 43 "tracing_resources.pak",
42 ] 44 ]
43 45
44 # resource_ids has an entry for our .grd file that looks like: 46 # resource_ids has an entry for our .grd file that looks like:
45 # "<(SHARED_INTERMEDIATE_DIR)/content/browser/tracing/tracing_resources.grd" 47 # "<(SHARED_INTERMEDIATE_DIR)/content/browser/tracing/tracing_resources.grd"
46 # and what we pass here should make that resolve to our .grd file. 48 # and what we pass here should make that resolve to our .grd file.
47 defines = 49 defines =
48 [ "SHARED_INTERMEDIATE_DIR=" + rebase_path(root_gen_dir, root_build_dir) ] 50 [ "SHARED_INTERMEDIATE_DIR=" + rebase_path(root_gen_dir, root_build_dir) ]
49 51
50 deps = [ 52 deps = [
51 ":generate_tracing_grd", 53 ":generate_tracing_grd",
52 ] 54 ]
53 } 55 }
OLDNEW
« no previous file with comments | « content/browser/devtools/BUILD.gn ('k') | third_party/google_input_tools/closure.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698