Optionally compute grit inputs precisely.

Optionally compute grit inputs precisely.

Adds a new flag that will cause grit inputs to be computed precisely by
calling out to grit at GN-time.

This is off by default so it won't impact the performance of the normal runs
for developers (where it is not necessary). This can be turned explicitly for
bots that use analyze.

Updates the closure compiler template so there's not a pass-through group
in the dependency chain. That group is not helping and because the deps
were not public, the input was not allowed by the generated grit file.

Remove the default value for the resource_ids file that grit_info used. The
Android build depends on not setting a resource ID for a few files where it's
not needed, and referring to the shared produced an error because there was
no entry for the files in the ID file.

BUG=639328
Committed: https://crrev.com/bd8c219c2282f2d6f238517c16c76b15fdf82f39
Cr-Commit-Position: refs/heads/master@{#422268}

[brettw, 2016-09-29 21:31:15]

Comment

[brettw, 2016-09-29 21:35:57]

fix

[brettw, 2016-09-29 21:37:24]

Description was changed from

==========
Optionally compute grit inputs precisely.

Adds a new flag that will cause grit inputs to be computed precisely by calling
out to grit at GN-time.

This is off by default so it won't impact the performance of the normal runs
for developers (where it is not necessary). This can be turned explicitly for
bots that use analyze.

BUG=639328
==========

to

==========
Optionally compute grit inputs precisely.

Adds a new flag that will cause grit inputs to be computed precisely by calling
out to grit at GN-time.

This is off by default so it won't impact the performance of the normal runs
for developers (where it is not necessary). This can be turned explicitly for
bots that use analyze.

Updates the closure compiler template so there's not a pass-through group
in the dependency chain. That group is not helping and because the deps
were not public, the input was not allowed by the generated grit file.

BUG=639328
==========

[brettw, 2016-09-29 21:37:24]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-09-29 21:37:27]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 21:38:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 21:42:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 21:42:04]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[brettw, 2016-09-29 22:44:03]

inputs

[brettw, 2016-09-29 22:44:51]

Note that the flag doesn't work on Android. Android sets the resource_ids file
to empty and this makes grit_info.py barf for some reason.

[brettw, 2016-09-29 22:44:57]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 22:45:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 22:55:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 22:55:08]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Dirk Pranke, 2016-09-30 16:31:59]

dpranke@chromium.org changed reviewers:
+ agrieve@chromium.org

[Dirk Pranke, 2016-09-30 16:32:00]

+agrieve

This more-or-less lgtm, but I don't understand enough about grit to understand
why Android wouldn't be using resource_ids; is that fixable?

[agrieve, 2016-09-30 17:52:35]

On 2016/09/30 16:32:00, Dirk Pranke wrote:
> +agrieve
> 
> This more-or-less lgtm, but I don't understand enough about grit to understand
> why Android wouldn't be using resource_ids; is that fixable?

I don't know either...

[brettw, 2016-09-30 22:21:58]

Remove implicit resource ids

[brettw, 2016-09-30 22:22:06]

I figured out Android. grit_info.py had a default value for the resource IDs
that wasn't there for the regular grit binary. I just removed the default value
(this current call is currently the only use of grit_info.py).

[brettw, 2016-09-30 22:22:16]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-09-30 22:22:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2375283004/#ps80001
(title: "Remove implicit resource ids")

[commit-bot: I haz the power, 2016-09-30 22:22:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-09-30 22:27:38]

Description was changed from

==========
Optionally compute grit inputs precisely.

Adds a new flag that will cause grit inputs to be computed precisely by calling
out to grit at GN-time.

This is off by default so it won't impact the performance of the normal runs
for developers (where it is not necessary). This can be turned explicitly for
bots that use analyze.

Updates the closure compiler template so there's not a pass-through group
in the dependency chain. That group is not helping and because the deps
were not public, the input was not allowed by the generated grit file.

BUG=639328
==========

to

==========
Optionally compute grit inputs precisely.

Adds a new flag that will cause grit inputs to be computed precisely by
calling out to grit at GN-time.

This is off by default so it won't impact the performance of the normal runs
for developers (where it is not necessary). This can be turned explicitly for
bots that use analyze.

Updates the closure compiler template so there's not a pass-through group
in the dependency chain. That group is not helping and because the deps
were not public, the input was not allowed by the generated grit file.

Remove the default value for the resource_ids file that grit_info used. The
Android build depends on not setting a resource ID for a few files where it's
not needed, and referring to the shared produced an error because there was
no entry for the files in the ID file.

BUG=639328
==========

[commit-bot: I haz the power, 2016-10-01 01:56:52]

Description was changed from

==========
Optionally compute grit inputs precisely.

Adds a new flag that will cause grit inputs to be computed precisely by
calling out to grit at GN-time.

This is off by default so it won't impact the performance of the normal runs
for developers (where it is not necessary). This can be turned explicitly for
bots that use analyze.

Updates the closure compiler template so there's not a pass-through group
in the dependency chain. That group is not helping and because the deps
were not public, the input was not allowed by the generated grit file.

Remove the default value for the resource_ids file that grit_info used. The
Android build depends on not setting a resource ID for a few files where it's
not needed, and referring to the shared produced an error because there was
no entry for the files in the ID file.

BUG=639328
==========

to

==========
Optionally compute grit inputs precisely.

Adds a new flag that will cause grit inputs to be computed precisely by
calling out to grit at GN-time.

This is off by default so it won't impact the performance of the normal runs
for developers (where it is not necessary). This can be turned explicitly for
bots that use analyze.

Updates the closure compiler template so there's not a pass-through group
in the dependency chain. That group is not helping and because the deps
were not public, the input was not allowed by the generated grit file.

Remove the default value for the resource_ids file that grit_info used. The
Android build depends on not setting a resource ID for a few files where it's
not needed, and referring to the shared produced an error because there was
no entry for the files in the ID file.

BUG=639328
==========

[commit-bot: I haz the power, 2016-10-01 01:56:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-01 02:01:21]

Description was changed from

==========
Optionally compute grit inputs precisely.

Adds a new flag that will cause grit inputs to be computed precisely by
calling out to grit at GN-time.

This is off by default so it won't impact the performance of the normal runs
for developers (where it is not necessary). This can be turned explicitly for
bots that use analyze.

Updates the closure compiler template so there's not a pass-through group
in the dependency chain. That group is not helping and because the deps
were not public, the input was not allowed by the generated grit file.

Remove the default value for the resource_ids file that grit_info used. The
Android build depends on not setting a resource ID for a few files where it's
not needed, and referring to the shared produced an error because there was
no entry for the files in the ID file.

BUG=639328
==========

to

==========
Optionally compute grit inputs precisely.

Adds a new flag that will cause grit inputs to be computed precisely by
calling out to grit at GN-time.

This is off by default so it won't impact the performance of the normal runs
for developers (where it is not necessary). This can be turned explicitly for
bots that use analyze.

Updates the closure compiler template so there's not a pass-through group
in the dependency chain. That group is not helping and because the deps
were not public, the input was not allowed by the generated grit file.

Remove the default value for the resource_ids file that grit_info used. The
Android build depends on not setting a resource ID for a few files where it's
not needed, and referring to the shared produced an error because there was
no entry for the files in the ID file.

BUG=639328

Committed: https://crrev.com/bd8c219c2282f2d6f238517c16c76b15fdf82f39
Cr-Commit-Position: refs/heads/master@{#422268}
==========

[commit-bot: I haz the power, 2016-10-01 02:01:23]

Patchset 5 (id:??) landed as
https://crrev.com/bd8c219c2282f2d6f238517c16c76b15fdf82f39
Cr-Commit-Position: refs/heads/master@{#422268}