Fix tests FullscreenFileURL, TestTabDoesntExitFullscreenOnSubFrameNavigation

Fix tests FullscreenFileURL, TestTabDoesntExitFullscreenOnSubFrameNavigation

These are failing with "Check failed: !IsPathAbsolute(appended)." when
run with --gtest_also_run_disabled_tests. Removing the leading slash
from the kSimpleFile constant fixes it.

BUG=651272
Committed: https://crrev.com/86d5b6c3d7aa2e2c28becafe642fcc6d7be405c9
Cr-Commit-Position: refs/heads/master@{#421748}

[tapted, 2016-09-29 01:37:34]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[tapted, 2016-09-29 01:37:46]

Description was changed from

==========
Fix tests FullscreenFileURL, TestTabDoesntExitFullscreenOnSubFrameNavigation

These are failing with "Check failed: !IsPathAbsolute(appended)." when
run with --gtest_als-_run_disabled_tests. Removing the leading slash
from the kSimpleFile constant fixes it.

BUG=651272
==========

to

==========
Fix tests FullscreenFileURL, TestTabDoesntExitFullscreenOnSubFrameNavigation

These are failing with "Check failed: !IsPathAbsolute(appended)." when
run with --gtest_als-_run_disabled_tests. Removing the leading slash
from the kSimpleFile constant fixes it.

BUG=651272
==========

[tapted, 2016-09-29 01:37:46]

tapted@chromium.org changed reviewers:
+ mgiuca@chromium.org

[commit-bot: I haz the power, 2016-09-29 01:38:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-09-29 01:38:56]

Description was changed from

==========
Fix tests FullscreenFileURL, TestTabDoesntExitFullscreenOnSubFrameNavigation

These are failing with "Check failed: !IsPathAbsolute(appended)." when
run with --gtest_als-_run_disabled_tests. Removing the leading slash
from the kSimpleFile constant fixes it.

BUG=651272
==========

to

==========
Fix tests FullscreenFileURL, TestTabDoesntExitFullscreenOnSubFrameNavigation

These are failing with "Check failed: !IsPathAbsolute(appended)." when
run with --gtest_also_run_disabled_tests. Removing the leading slash
from the kSimpleFile constant fixes it.

BUG=651272
==========

[commit-bot: I haz the power, 2016-09-29 02:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 02:23:38]

Dry run: This issue passed the CQ dry run.

[Matt Giuca, 2016-09-29 03:39:28]

Can we re-enable these tests now?

[tapted, 2016-09-29 03:45:55]

On 2016/09/29 03:39:28, Matt Giuca (OOO til Oct 4) wrote:
> Can we re-enable these tests now?

Possibly on Mac, and possibly better in combination with the fullscreen "Faker"
I wrote for Mac. But I haven't done anything to address the flakiness from
http://cbrug.com/146006 (Linux issue). Fullscreen transitions are notoriously
flaky on all platforms, so if we try to run these on the bots again, it should
be a separate change.

[Matt Giuca, 2016-09-29 03:50:33]

On 2016/09/29 03:45:55, tapted wrote:
> On 2016/09/29 03:39:28, Matt Giuca (OOO til Oct 4) wrote:
> > Can we re-enable these tests now?
> 
> Possibly on Mac, and possibly better in combination with the fullscreen
"Faker"
> I wrote for Mac. But I haven't done anything to address the flakiness from
> http://cbrug.com/146006 (Linux issue). Fullscreen transitions are notoriously
> flaky on all platforms, so if we try to run these on the bots again, it should
> be a separate change.

OK, yeah this is part of a larger project of fixing all those disabled tests. I
don't expect you to do that, but *maybe* you could re-enable those 3 tests in a
follow-up CL (this one, and the two mentioned in
https://codereview.chromium.org/2378623003/) and we can just see if they are
still flaky.

[Matt Giuca, 2016-09-29 03:50:38]

lgtm

[tapted, 2016-09-29 04:47:04]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-09-29 04:47:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 04:53:22]

Description was changed from

==========
Fix tests FullscreenFileURL, TestTabDoesntExitFullscreenOnSubFrameNavigation

These are failing with "Check failed: !IsPathAbsolute(appended)." when
run with --gtest_also_run_disabled_tests. Removing the leading slash
from the kSimpleFile constant fixes it.

BUG=651272
==========

to

==========
Fix tests FullscreenFileURL, TestTabDoesntExitFullscreenOnSubFrameNavigation

These are failing with "Check failed: !IsPathAbsolute(appended)." when
run with --gtest_also_run_disabled_tests. Removing the leading slash
from the kSimpleFile constant fixes it.

BUG=651272
==========

[commit-bot: I haz the power, 2016-09-29 04:53:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-29 04:55:44]

Description was changed from

==========
Fix tests FullscreenFileURL, TestTabDoesntExitFullscreenOnSubFrameNavigation

These are failing with "Check failed: !IsPathAbsolute(appended)." when
run with --gtest_also_run_disabled_tests. Removing the leading slash
from the kSimpleFile constant fixes it.

BUG=651272
==========

to

==========
Fix tests FullscreenFileURL, TestTabDoesntExitFullscreenOnSubFrameNavigation

These are failing with "Check failed: !IsPathAbsolute(appended)." when
run with --gtest_also_run_disabled_tests. Removing the leading slash
from the kSimpleFile constant fixes it.

BUG=651272

Committed: https://crrev.com/86d5b6c3d7aa2e2c28becafe642fcc6d7be405c9
Cr-Commit-Position: refs/heads/master@{#421748}
==========

[commit-bot: I haz the power, 2016-09-29 04:55:44]

Patchset 1 (id:??) landed as
https://crrev.com/86d5b6c3d7aa2e2c28becafe642fcc6d7be405c9
Cr-Commit-Position: refs/heads/master@{#421748}