Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: runtime/observatory/BUILD.gn

Issue 2375263003: Enable compression of observatory_assets.tar in standalone GN build (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/BUILD.gn
diff --git a/runtime/observatory/BUILD.gn b/runtime/observatory/BUILD.gn
index a476414b477f8722685288e99add32551c7c5f79..fc7af6a8b788af9aa49d1abbbc3ef1e246cee6d3 100644
--- a/runtime/observatory/BUILD.gn
+++ b/runtime/observatory/BUILD.gn
@@ -160,6 +160,10 @@ template("observatory_archive") {
"Need inner_namespace in $target_name")
assert(defined(invoker.outer_namespace),
"Need outer_namespace in $target_name")
+ enable_compression = false
+ if (defined(invoker.compress) && invoker.compress) {
+ enable_compression = true
+ }
action(target_name) {
deps = [
":deploy_observatory",
@@ -167,10 +171,10 @@ template("observatory_archive") {
script = "../tools/create_archive.py"
- inputs = [
- script,
- "$root_out_dir/observatory/deployed/web/main.dart.js",
- ]
+ inputs = [
+ script,
+ "$root_out_dir/observatory/deployed/web/main.dart.js",
+ ]
inner_namespace = invoker.inner_namespace
outer_namespace = invoker.outer_namespace
@@ -185,6 +189,9 @@ template("observatory_archive") {
"--name", "observatory_assets_archive",
"--client_root", rebase_path("$root_out_dir/observatory/deployed/web/"),
]
+ if (enable_compression) {
+ args += [ "--compress" ]
+ }
outputs = [
"$root_gen_dir/observatory/${output_name}.cc",
@@ -209,6 +216,7 @@ source_set("embedded_observatory_archive") {
}
observatory_archive("standalone_archive_observatory") {
+ compress = true
outer_namespace = "dart"
inner_namespace = "bin"
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698