chrome/browser/resources/settings/reset_page/reset_profile_banner.js - Issue 2375223002: md-settings: Fix back navigation from /resetProfileSettings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/reset_page/reset_profile_banner.js

Issue 2375223002: md-settings: Fix back navigation from /resetProfileSettings. (Closed)

Patch Set: Fix failing test. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/reset_page/reset_profile_banner.html ('k') | chrome/browser/resources/settings/reset_page/reset_profile_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/reset_page/reset_profile_banner.js

diff --git a/chrome/browser/resources/settings/reset_page/reset_profile_banner.js b/chrome/browser/resources/settings/reset_page/reset_profile_banner.js

index 4c5aa929d0848ced1a7ce76dd419f0abd7084800..4ce02ea192b98643e2757ea6d500d4bc1d1da988 100644

--- a/chrome/browser/resources/settings/reset_page/reset_profile_banner.js

+++ b/chrome/browser/resources/settings/reset_page/reset_profile_banner.js

@@ -24,18 +24,15 @@ Polymer({

/**

- * Creates and shows a <settings-reset-profile-dialog>.

+ * Shows a <settings-reset-profile-dialog>.

* @private

- showDialog_: function(dialogName) {

+ showDialog_: function() {

this.showResetProfileDialog_ = true;

- this.async(function() {

- var dialog = this.$$('settings-reset-profile-dialog');

- dialog.open();

- }.bind(this));

- onResetDone_: function() {

+ /** @private */

+ onDialogClose_: function() {

this.showResetProfileDialog_ = false;

});