third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp - Issue 2375203003: Parent stacking context of a backdrop filter should isolate itself

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

Issue 2375203003: Parent stacking context of a backdrop filter should isolate itself (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/css3/filters/backdrop-filter-isolation.html ('K') | « third_party/WebKit/LayoutTests/css3/filters/backdrop-filter-isolation-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

index e30b112a0200fc1eb6328806e5164ece24a8b69e..dad1213192b3462721a72c01cabd4c1943047de7 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

@@ -428,7 +428,7 @@ void CompositingRequirementsUpdater::updateRecursive(PaintLayer* ancestorLayer,

reflectionLayer->setCompositingReasons(reflectionCompositingReason, CompositingReasonReflectionOfCompositedParent);

}

- if (willBeCompositedOrSquashed && layer->layoutObject()->style()->hasBlendMode())

+ if (willBeCompositedOrSquashed && (layer->layoutObject()->style()->hasBlendMode() || layer->layoutObject()->style()->hasBackdropFilter()))

pdr. 2016/09/29 21:54:49 Since webkit has the only shipping implementation

trchen 2016/09/29 22:23:33 Sure! I'm doing now.

currentRecursionData.m_hasUnisolatedCompositedBlendingDescendant = true;

// Tell the parent it has compositing descendants.