Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: content/browser/android/app_web_message_port_service_impl.cc

Issue 2375133002: Move MessagePort implementation from android_webview to content (Closed)
Patch Set: rsesek nits and git cl format Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/app_web_message_port_service_impl.cc
diff --git a/android_webview/native/aw_message_port_service_impl.cc b/content/browser/android/app_web_message_port_service_impl.cc
similarity index 49%
rename from android_webview/native/aw_message_port_service_impl.cc
rename to content/browser/android/app_web_message_port_service_impl.cc
index bc55c23bb74386ff764ca033a575f2e2d045af6c..2dd13b907b6823d3517fc697f9212c2ca2c9c1a5 100644
--- a/android_webview/native/aw_message_port_service_impl.cc
+++ b/content/browser/android/app_web_message_port_service_impl.cc
@@ -2,19 +2,20 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "android_webview/native/aw_message_port_service_impl.h"
+#include "content/browser/android/app_web_message_port_service_impl.h"
-#include "android_webview/browser/aw_browser_context.h"
-#include "android_webview/browser/aw_message_port_message_filter.h"
-#include "android_webview/native/aw_contents.h"
#include "base/android/jni_array.h"
#include "base/android/jni_string.h"
#include "base/bind.h"
+#include "content/browser/android/app_web_message_port_message_filter.h"
+#include "content/browser/message_port_service.h"
+#include "content/browser/renderer_host/render_process_host_impl.h"
+#include "content/browser/web_contents/web_contents_impl.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/message_port_provider.h"
-#include "jni/AwMessagePortService_jni.h"
+#include "jni/AppWebMessagePortService_jni.h"
-namespace android_webview {
+namespace content {
using base::android::AttachCurrentThread;
using base::android::ConvertJavaStringToUTF16;
@@ -26,33 +27,35 @@ using base::android::ToJavaIntArray;
using content::BrowserThread;
using content::MessagePortProvider;
-// static
-AwMessagePortServiceImpl* AwMessagePortServiceImpl::GetInstance() {
- return static_cast<AwMessagePortServiceImpl*>(
- AwBrowserContext::GetDefault()->GetMessagePortService());
+AppWebMessagePortServiceImpl* AppWebMessagePortServiceImpl::GetInstance() {
+ return base::Singleton<AppWebMessagePortServiceImpl>::get();
}
-AwMessagePortServiceImpl::AwMessagePortServiceImpl() {
-}
+AppWebMessagePortServiceImpl::AppWebMessagePortServiceImpl() {}
-AwMessagePortServiceImpl::~AwMessagePortServiceImpl() {
+AppWebMessagePortServiceImpl::~AppWebMessagePortServiceImpl() {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
if (obj.is_null())
return;
- Java_AwMessagePortService_unregisterNativeAwMessagePortService(env, obj);
+ Java_AppWebMessagePortService_unregisterNativeAppWebMessagePortService(env,
+ obj);
}
-void AwMessagePortServiceImpl::Init(JNIEnv* env, jobject obj) {
+void AppWebMessagePortServiceImpl::Init(JNIEnv* env, jobject obj) {
java_ref_ = JavaObjectWeakGlobalRef(env, obj);
}
-void AwMessagePortServiceImpl::CreateMessageChannel(
+void AppWebMessagePortServiceImpl::CreateMessageChannel(
JNIEnv* env,
jobjectArray ports,
- scoped_refptr<AwMessagePortMessageFilter> filter) {
+ WebContents* web_contents) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
-
+ RenderFrameHostImpl* rfh =
+ static_cast<RenderFrameHostImpl*>(web_contents->GetMainFrame());
+ int routing_id = web_contents->GetMainFrame()->GetRoutingID();
+ scoped_refptr<AppWebMessagePortMessageFilter> filter =
+ rfh->GetAppWebMessagePortMessageFilter(routing_id);
ScopedJavaGlobalRef<jobjectArray>* j_ports =
new ScopedJavaGlobalRef<jobjectArray>();
j_ports->Reset(env, ports);
@@ -60,21 +63,15 @@ void AwMessagePortServiceImpl::CreateMessageChannel(
int* portId1 = new int;
int* portId2 = new int;
BrowserThread::PostTaskAndReply(
- BrowserThread::IO,
- FROM_HERE,
- base::Bind(&AwMessagePortServiceImpl::CreateMessageChannelOnIOThread,
- base::Unretained(this),
- filter,
- portId1,
- portId2),
- base::Bind(&AwMessagePortServiceImpl::OnMessageChannelCreated,
- base::Unretained(this),
- base::Owned(j_ports),
- base::Owned(portId1),
- base::Owned(portId2)));
-}
-
-void AwMessagePortServiceImpl::OnConvertedWebToAppMessage(
+ BrowserThread::IO, FROM_HERE,
+ base::Bind(&AppWebMessagePortServiceImpl::CreateMessageChannelOnIOThread,
+ base::Unretained(this), filter, portId1, portId2),
+ base::Bind(&AppWebMessagePortServiceImpl::OnMessageChannelCreated,
+ base::Unretained(this), base::Owned(j_ports),
+ base::Owned(portId1), base::Owned(portId2)));
+}
+
+void AppWebMessagePortServiceImpl::OnConvertedWebToAppMessage(
int message_port_id,
const base::ListValue& message,
const std::vector<int>& sent_message_port_ids) {
@@ -87,7 +84,7 @@ void AwMessagePortServiceImpl::OnConvertedWebToAppMessage(
base::string16 value;
if (!message.GetString(0, &value)) {
LOG(WARNING) << "Converting post message to a string failed for port "
- << message_port_id;
+ << message_port_id;
return;
}
@@ -96,7 +93,7 @@ void AwMessagePortServiceImpl::OnConvertedWebToAppMessage(
return;
}
- // Add the ports to AwMessagePortService.
+ // Add the ports to AppWebMessagePortService.
for (const auto& iter : sent_message_port_ids) {
AddPort(iter, ports_[message_port_id]);
}
@@ -104,22 +101,22 @@ void AwMessagePortServiceImpl::OnConvertedWebToAppMessage(
ScopedJavaLocalRef<jstring> jmsg = ConvertUTF16ToJavaString(env, value);
ScopedJavaLocalRef<jintArray> jports =
ToJavaIntArray(env, sent_message_port_ids);
- Java_AwMessagePortService_onReceivedMessage(env, jobj, message_port_id, jmsg,
- jports);
+ Java_AppWebMessagePortService_onReceivedMessage(env, jobj, message_port_id,
+ jmsg, jports);
}
-void AwMessagePortServiceImpl::OnMessagePortMessageFilterClosing(
- AwMessagePortMessageFilter* filter) {
+void AppWebMessagePortServiceImpl::OnMessagePortMessageFilterClosing(
+ AppWebMessagePortMessageFilter* filter) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- for (MessagePorts::iterator iter = ports_.begin();
- iter != ports_.end(); iter++) {
+ for (MessagePorts::iterator iter = ports_.begin(); iter != ports_.end();
+ iter++) {
if (iter->second == filter) {
ports_.erase(iter);
}
}
}
-void AwMessagePortServiceImpl::PostAppToWebMessage(
+void AppWebMessagePortServiceImpl::PostAppToWebMessage(
JNIEnv* env,
const JavaParamRef<jobject>& obj,
int sender_id,
@@ -133,12 +130,9 @@ void AwMessagePortServiceImpl::PostAppToWebMessage(
base::android::JavaIntArrayToIntVector(env, sent_ports, j_sent_ports);
BrowserThread::PostTask(
- BrowserThread::IO,
- FROM_HERE,
- base::Bind(&AwMessagePortServiceImpl::PostAppToWebMessageOnIOThread,
- base::Unretained(this),
- sender_id,
- base::Owned(j_message),
+ BrowserThread::IO, FROM_HERE,
+ base::Bind(&AppWebMessagePortServiceImpl::PostAppToWebMessageOnIOThread,
+ base::Unretained(this), sender_id, base::Owned(j_message),
base::Owned(j_sent_ports)));
}
@@ -146,29 +140,29 @@ void AwMessagePortServiceImpl::PostAppToWebMessage(
// it is possible that messages are still queued in the renderer process
// waiting for a conversion. Instead, it sends a special message with
// a flag which indicates that this message port should be closed.
-void AwMessagePortServiceImpl::ClosePort(JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- int message_port_id) {
+void AppWebMessagePortServiceImpl::ClosePort(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ int message_port_id) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(
- BrowserThread::IO,
- FROM_HERE,
- base::Bind(&AwMessagePortServiceImpl::PostClosePortMessage,
- base::Unretained(this),
- message_port_id));
+ BrowserThread::IO, FROM_HERE,
+ base::Bind(&AppWebMessagePortServiceImpl::PostClosePortMessage,
+ base::Unretained(this), message_port_id));
}
-void AwMessagePortServiceImpl::ReleaseMessages(JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- int message_port_id) {
+void AppWebMessagePortServiceImpl::ReleaseMessages(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ int message_port_id) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(
- BrowserThread::IO,
- FROM_HERE,
- base::Bind(&MessagePortProvider::ReleaseMessages, message_port_id));
+ BrowserThread::IO, FROM_HERE,
+ base::Bind(&MessagePortService::ReleaseMessages,
+ base::Unretained(MessagePortService::GetInstance()),
+ message_port_id));
}
-void AwMessagePortServiceImpl::RemoveSentPorts(
+void AppWebMessagePortServiceImpl::RemoveSentPorts(
const std::vector<int>& sent_ports) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
// Remove the filters that are associated with the transferred ports
@@ -176,7 +170,7 @@ void AwMessagePortServiceImpl::RemoveSentPorts(
ports_.erase(iter);
}
-void AwMessagePortServiceImpl::PostAppToWebMessageOnIOThread(
+void AppWebMessagePortServiceImpl::PostAppToWebMessageOnIOThread(
int sender_id,
base::string16* message,
std::vector<int>* sent_ports) {
@@ -184,28 +178,39 @@ void AwMessagePortServiceImpl::PostAppToWebMessageOnIOThread(
ports_[sender_id]->SendAppToWebMessage(sender_id, *message, *sent_ports);
}
-void AwMessagePortServiceImpl::PostClosePortMessage(int message_port_id) {
+void AppWebMessagePortServiceImpl::PostClosePortMessage(int message_port_id) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
ports_[message_port_id]->SendClosePortMessage(message_port_id);
}
-void AwMessagePortServiceImpl::CleanupPort(int message_port_id) {
+void AppWebMessagePortServiceImpl::CleanupPort(int message_port_id) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
ports_.erase(message_port_id);
}
-void AwMessagePortServiceImpl::CreateMessageChannelOnIOThread(
- scoped_refptr<AwMessagePortMessageFilter> filter,
+void AppWebMessagePortServiceImpl::CreateMessageChannelOnIOThread(
+ scoped_refptr<AppWebMessagePortMessageFilter> filter,
int* portId1,
int* portId2) {
- MessagePortProvider::CreateMessageChannel(filter.get(), portId1, portId2);
- MessagePortProvider::HoldMessages(*portId1);
- MessagePortProvider::HoldMessages(*portId2);
+ *portId1 = 0;
+ *portId2 = 0;
+ MessagePortService* msp = MessagePortService::GetInstance();
+ msp->Create(MSG_ROUTING_NONE, filter.get(), portId1);
+ msp->Create(MSG_ROUTING_NONE, filter.get(), portId2);
+ // Update the routing number of the message ports to be equal to the message
+ // port numbers.
+ msp->UpdateMessagePort(*portId1, filter.get(), *portId1);
+ msp->UpdateMessagePort(*portId2, filter.get(), *portId2);
+ msp->Entangle(*portId1, *portId2);
+ msp->Entangle(*portId2, *portId1);
+
+ msp->HoldMessages(*portId1);
+ msp->HoldMessages(*portId2);
AddPort(*portId1, filter.get());
AddPort(*portId2, filter.get());
}
-void AwMessagePortServiceImpl::OnMessageChannelCreated(
+void AppWebMessagePortServiceImpl::OnMessageChannelCreated(
ScopedJavaGlobalRef<jobjectArray>* ports,
int* port1,
int* port2) {
@@ -214,13 +219,14 @@ void AwMessagePortServiceImpl::OnMessageChannelCreated(
ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
if (obj.is_null())
return;
- Java_AwMessagePortService_onMessageChannelCreated(env, obj, *port1, *port2,
- *ports);
+ Java_AppWebMessagePortService_onMessageChannelCreated(env, obj, *port1,
+ *port2, *ports);
}
// Adds a new port to the message port service.
-void AwMessagePortServiceImpl::AddPort(int message_port_id,
- AwMessagePortMessageFilter* filter) {
+void AppWebMessagePortServiceImpl::AddPort(
+ int message_port_id,
+ AppWebMessagePortMessageFilter* filter) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (ports_.count(message_port_id)) {
NOTREACHED();
@@ -229,15 +235,17 @@ void AwMessagePortServiceImpl::AddPort(int message_port_id,
ports_[message_port_id] = filter;
}
-bool RegisterAwMessagePortService(JNIEnv* env) {
+bool RegisterAppWebMessagePortService(JNIEnv* env) {
return RegisterNativesImpl(env);
}
// static
-jlong InitAwMessagePortService(JNIEnv* env, const JavaParamRef<jobject>& obj) {
- AwMessagePortServiceImpl* service = AwMessagePortServiceImpl::GetInstance();
+jlong InitAppWebMessagePortService(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
+ AppWebMessagePortServiceImpl* service =
+ AppWebMessagePortServiceImpl::GetInstance();
service->Init(env, obj);
return reinterpret_cast<intptr_t>(service);
}
-} // namespace android_webview
+} // namespace content
« no previous file with comments | « content/browser/android/app_web_message_port_service_impl.h ('k') | content/browser/android/browser_jni_registrar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698