Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: content/browser/android/app_web_message_port_service_impl.cc

Issue 2375133002: Move MessagePort implementation from android_webview to content (Closed)
Patch Set: added ifdef Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_message_port_service_impl.h" 5 #include "content/browser/android/app_web_message_port_service_impl.h"
6 6
7 #include "android_webview/browser/aw_browser_context.h"
8 #include "android_webview/browser/aw_message_port_message_filter.h"
9 #include "android_webview/native/aw_contents.h"
10 #include "base/android/jni_array.h" 7 #include "base/android/jni_array.h"
11 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
12 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "content/browser/android/app_web_message_port_message_filter.h"
11 #include "content/browser/message_port_service.h"
12 #include "content/browser/renderer_host/render_process_host_impl.h"
13 #include "content/browser/web_contents/web_contents_impl.h"
13 #include "content/public/browser/browser_thread.h" 14 #include "content/public/browser/browser_thread.h"
14 #include "content/public/browser/message_port_provider.h" 15 #include "content/public/browser/message_port_provider.h"
15 #include "jni/AwMessagePortService_jni.h" 16 #include "jni/AppWebMessagePortService_jni.h"
16 17
17 namespace android_webview { 18 namespace content {
18 19
19 using base::android::AttachCurrentThread; 20 using base::android::AttachCurrentThread;
20 using base::android::ConvertJavaStringToUTF16; 21 using base::android::ConvertJavaStringToUTF16;
21 using base::android::ConvertUTF16ToJavaString; 22 using base::android::ConvertUTF16ToJavaString;
22 using base::android::JavaParamRef; 23 using base::android::JavaParamRef;
23 using base::android::ScopedJavaGlobalRef; 24 using base::android::ScopedJavaGlobalRef;
24 using base::android::ScopedJavaLocalRef; 25 using base::android::ScopedJavaLocalRef;
25 using base::android::ToJavaIntArray; 26 using base::android::ToJavaIntArray;
26 using content::BrowserThread; 27 using content::BrowserThread;
27 using content::MessagePortProvider; 28 using content::MessagePortProvider;
28 29
29 // static 30 AppWebMessagePortServiceImpl* AppWebMessagePortServiceImpl::GetInstance() {
30 AwMessagePortServiceImpl* AwMessagePortServiceImpl::GetInstance() { 31 return base::Singleton<AppWebMessagePortServiceImpl>::get();
31 return static_cast<AwMessagePortServiceImpl*>(
32 AwBrowserContext::GetDefault()->GetMessagePortService());
33 } 32 }
34 33
35 AwMessagePortServiceImpl::AwMessagePortServiceImpl() { 34 AppWebMessagePortServiceImpl::AppWebMessagePortServiceImpl() {
36 } 35 }
37 36
38 AwMessagePortServiceImpl::~AwMessagePortServiceImpl() { 37 AppWebMessagePortServiceImpl::~AppWebMessagePortServiceImpl() {
39 JNIEnv* env = AttachCurrentThread(); 38 JNIEnv* env = AttachCurrentThread();
40 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env); 39 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
41 if (obj.is_null()) 40 if (obj.is_null())
42 return; 41 return;
43 Java_AwMessagePortService_unregisterNativeAwMessagePortService(env, obj); 42 Java_AppWebMessagePortService_unregisterNativeAppWebMessagePortService(env,
43 obj);
44 } 44 }
45 45
46 void AwMessagePortServiceImpl::Init(JNIEnv* env, jobject obj) { 46 void AppWebMessagePortServiceImpl::Init(JNIEnv* env, jobject obj) {
47 java_ref_ = JavaObjectWeakGlobalRef(env, obj); 47 java_ref_ = JavaObjectWeakGlobalRef(env, obj);
48 } 48 }
49 49
50 void AwMessagePortServiceImpl::CreateMessageChannel( 50 void AppWebMessagePortServiceImpl::CreateMessageChannel(
51 JNIEnv* env, 51 JNIEnv* env,
52 jobjectArray ports, 52 jobjectArray ports,
53 scoped_refptr<AwMessagePortMessageFilter> filter) { 53 WebContents* web_contents) {
54 DCHECK_CURRENTLY_ON(BrowserThread::UI); 54 DCHECK_CURRENTLY_ON(BrowserThread::UI);
55 55 RenderFrameHostImpl* rfh =
56 static_cast<RenderFrameHostImpl*>(web_contents->GetMainFrame());
57 int routing_id = web_contents->GetMainFrame()->GetRoutingID();
58 scoped_refptr<AppWebMessagePortMessageFilter> filter =
59 rfh->GetAppWebMessagePortMessageFilter(routing_id);
56 ScopedJavaGlobalRef<jobjectArray>* j_ports = 60 ScopedJavaGlobalRef<jobjectArray>* j_ports =
57 new ScopedJavaGlobalRef<jobjectArray>(); 61 new ScopedJavaGlobalRef<jobjectArray>();
58 j_ports->Reset(env, ports); 62 j_ports->Reset(env, ports);
59 63
60 int* portId1 = new int; 64 int* portId1 = new int;
61 int* portId2 = new int; 65 int* portId2 = new int;
62 BrowserThread::PostTaskAndReply( 66 BrowserThread::PostTaskAndReply(
63 BrowserThread::IO, 67 BrowserThread::IO,
64 FROM_HERE, 68 FROM_HERE,
65 base::Bind(&AwMessagePortServiceImpl::CreateMessageChannelOnIOThread, 69 base::Bind(&AppWebMessagePortServiceImpl::CreateMessageChannelOnIOThread,
66 base::Unretained(this), 70 base::Unretained(this),
67 filter, 71 filter,
68 portId1, 72 portId1,
69 portId2), 73 portId2),
70 base::Bind(&AwMessagePortServiceImpl::OnMessageChannelCreated, 74 base::Bind(&AppWebMessagePortServiceImpl::OnMessageChannelCreated,
71 base::Unretained(this), 75 base::Unretained(this),
72 base::Owned(j_ports), 76 base::Owned(j_ports),
73 base::Owned(portId1), 77 base::Owned(portId1),
74 base::Owned(portId2))); 78 base::Owned(portId2)));
75 } 79 }
76 80
77 void AwMessagePortServiceImpl::OnConvertedWebToAppMessage( 81 void AppWebMessagePortServiceImpl::OnConvertedWebToAppMessage(
78 int message_port_id, 82 int message_port_id,
79 const base::ListValue& message, 83 const base::ListValue& message,
80 const std::vector<int>& sent_message_port_ids) { 84 const std::vector<int>& sent_message_port_ids) {
81 DCHECK_CURRENTLY_ON(BrowserThread::IO); 85 DCHECK_CURRENTLY_ON(BrowserThread::IO);
82 JNIEnv* env = AttachCurrentThread(); 86 JNIEnv* env = AttachCurrentThread();
83 ScopedJavaLocalRef<jobject> jobj = java_ref_.get(env); 87 ScopedJavaLocalRef<jobject> jobj = java_ref_.get(env);
84 if (jobj.is_null()) 88 if (jobj.is_null())
85 return; 89 return;
86 90
87 base::string16 value; 91 base::string16 value;
88 if (!message.GetString(0, &value)) { 92 if (!message.GetString(0, &value)) {
89 LOG(WARNING) << "Converting post message to a string failed for port " 93 LOG(WARNING) << "Converting post message to a string failed for port "
90 << message_port_id; 94 << message_port_id;
91 return; 95 return;
92 } 96 }
93 97
94 if (message.GetSize() != 1) { 98 if (message.GetSize() != 1) {
95 NOTREACHED(); 99 NOTREACHED();
96 return; 100 return;
97 } 101 }
98 102
99 // Add the ports to AwMessagePortService. 103 // Add the ports to AppWebMessagePortService.
100 for (const auto& iter : sent_message_port_ids) { 104 for (const auto& iter : sent_message_port_ids) {
101 AddPort(iter, ports_[message_port_id]); 105 AddPort(iter, ports_[message_port_id]);
102 } 106 }
103 107
104 ScopedJavaLocalRef<jstring> jmsg = ConvertUTF16ToJavaString(env, value); 108 ScopedJavaLocalRef<jstring> jmsg = ConvertUTF16ToJavaString(env, value);
105 ScopedJavaLocalRef<jintArray> jports = 109 ScopedJavaLocalRef<jintArray> jports =
106 ToJavaIntArray(env, sent_message_port_ids); 110 ToJavaIntArray(env, sent_message_port_ids);
107 Java_AwMessagePortService_onReceivedMessage(env, jobj, message_port_id, jmsg, 111 Java_AppWebMessagePortService_onReceivedMessage(env,
112 jobj,
Robert Sesek 2016/10/11 15:44:33 nit: alignment
Yusuf 2016/10/11 16:48:47 Done.
113 message_port_id,
114 jmsg,
108 jports); 115 jports);
109 } 116 }
110 117
111 void AwMessagePortServiceImpl::OnMessagePortMessageFilterClosing( 118 void AppWebMessagePortServiceImpl::OnMessagePortMessageFilterClosing(
112 AwMessagePortMessageFilter* filter) { 119 AppWebMessagePortMessageFilter* filter) {
113 DCHECK_CURRENTLY_ON(BrowserThread::IO); 120 DCHECK_CURRENTLY_ON(BrowserThread::IO);
114 for (MessagePorts::iterator iter = ports_.begin(); 121 for (MessagePorts::iterator iter = ports_.begin();
115 iter != ports_.end(); iter++) { 122 iter != ports_.end(); iter++) {
116 if (iter->second == filter) { 123 if (iter->second == filter) {
117 ports_.erase(iter); 124 ports_.erase(iter);
118 } 125 }
119 } 126 }
120 } 127 }
121 128
122 void AwMessagePortServiceImpl::PostAppToWebMessage( 129 void AppWebMessagePortServiceImpl::PostAppToWebMessage(
123 JNIEnv* env, 130 JNIEnv* env,
124 const JavaParamRef<jobject>& obj, 131 const JavaParamRef<jobject>& obj,
125 int sender_id, 132 int sender_id,
126 const JavaParamRef<jstring>& message, 133 const JavaParamRef<jstring>& message,
127 const JavaParamRef<jintArray>& sent_ports) { 134 const JavaParamRef<jintArray>& sent_ports) {
128 DCHECK_CURRENTLY_ON(BrowserThread::UI); 135 DCHECK_CURRENTLY_ON(BrowserThread::UI);
129 base::string16* j_message = new base::string16; 136 base::string16* j_message = new base::string16;
130 ConvertJavaStringToUTF16(env, message, j_message); 137 ConvertJavaStringToUTF16(env, message, j_message);
131 std::vector<int>* j_sent_ports = new std::vector<int>; 138 std::vector<int>* j_sent_ports = new std::vector<int>;
132 if (sent_ports != nullptr) 139 if (sent_ports != nullptr)
133 base::android::JavaIntArrayToIntVector(env, sent_ports, j_sent_ports); 140 base::android::JavaIntArrayToIntVector(env, sent_ports, j_sent_ports);
134 141
135 BrowserThread::PostTask( 142 BrowserThread::PostTask(
136 BrowserThread::IO, 143 BrowserThread::IO,
137 FROM_HERE, 144 FROM_HERE,
138 base::Bind(&AwMessagePortServiceImpl::PostAppToWebMessageOnIOThread, 145 base::Bind(&AppWebMessagePortServiceImpl::PostAppToWebMessageOnIOThread,
139 base::Unretained(this), 146 base::Unretained(this),
140 sender_id, 147 sender_id,
141 base::Owned(j_message), 148 base::Owned(j_message),
142 base::Owned(j_sent_ports))); 149 base::Owned(j_sent_ports)));
143 } 150 }
144 151
145 // The message port service cannot immediately close the port, because 152 // The message port service cannot immediately close the port, because
146 // it is possible that messages are still queued in the renderer process 153 // it is possible that messages are still queued in the renderer process
147 // waiting for a conversion. Instead, it sends a special message with 154 // waiting for a conversion. Instead, it sends a special message with
148 // a flag which indicates that this message port should be closed. 155 // a flag which indicates that this message port should be closed.
149 void AwMessagePortServiceImpl::ClosePort(JNIEnv* env, 156 void AppWebMessagePortServiceImpl::ClosePort(JNIEnv* env,
150 const JavaParamRef<jobject>& obj, 157 const JavaParamRef<jobject>& obj,
151 int message_port_id) { 158 int message_port_id) {
152 DCHECK_CURRENTLY_ON(BrowserThread::UI); 159 DCHECK_CURRENTLY_ON(BrowserThread::UI);
153 BrowserThread::PostTask( 160 BrowserThread::PostTask(
154 BrowserThread::IO, 161 BrowserThread::IO,
155 FROM_HERE, 162 FROM_HERE,
156 base::Bind(&AwMessagePortServiceImpl::PostClosePortMessage, 163 base::Bind(&AppWebMessagePortServiceImpl::PostClosePortMessage,
157 base::Unretained(this), 164 base::Unretained(this),
158 message_port_id)); 165 message_port_id));
159 } 166 }
160 167
161 void AwMessagePortServiceImpl::ReleaseMessages(JNIEnv* env, 168 void AppWebMessagePortServiceImpl::ReleaseMessages(JNIEnv* env,
162 const JavaParamRef<jobject>& obj, 169 const JavaParamRef<jobject>& obj,
163 int message_port_id) { 170 int message_port_id) {
164 DCHECK_CURRENTLY_ON(BrowserThread::UI); 171 DCHECK_CURRENTLY_ON(BrowserThread::UI);
165 BrowserThread::PostTask( 172 BrowserThread::PostTask(
166 BrowserThread::IO, 173 BrowserThread::IO,
167 FROM_HERE, 174 FROM_HERE,
168 base::Bind(&MessagePortProvider::ReleaseMessages, message_port_id)); 175 base::Bind(&MessagePortService::ReleaseMessages,
176 base::Unretained(
177 MessagePortService::GetInstance()), message_port_id));
169 } 178 }
170 179
171 void AwMessagePortServiceImpl::RemoveSentPorts( 180 void AppWebMessagePortServiceImpl::RemoveSentPorts(
172 const std::vector<int>& sent_ports) { 181 const std::vector<int>& sent_ports) {
173 DCHECK_CURRENTLY_ON(BrowserThread::IO); 182 DCHECK_CURRENTLY_ON(BrowserThread::IO);
174 // Remove the filters that are associated with the transferred ports 183 // Remove the filters that are associated with the transferred ports
175 for (const auto& iter : sent_ports) 184 for (const auto& iter : sent_ports)
176 ports_.erase(iter); 185 ports_.erase(iter);
177 } 186 }
178 187
179 void AwMessagePortServiceImpl::PostAppToWebMessageOnIOThread( 188 void AppWebMessagePortServiceImpl::PostAppToWebMessageOnIOThread(
180 int sender_id, 189 int sender_id,
181 base::string16* message, 190 base::string16* message,
182 std::vector<int>* sent_ports) { 191 std::vector<int>* sent_ports) {
183 RemoveSentPorts(*sent_ports); 192 RemoveSentPorts(*sent_ports);
184 ports_[sender_id]->SendAppToWebMessage(sender_id, *message, *sent_ports); 193 ports_[sender_id]->SendAppToWebMessage(sender_id, *message, *sent_ports);
185 } 194 }
186 195
187 void AwMessagePortServiceImpl::PostClosePortMessage(int message_port_id) { 196 void AppWebMessagePortServiceImpl::PostClosePortMessage(int message_port_id) {
188 DCHECK_CURRENTLY_ON(BrowserThread::IO); 197 DCHECK_CURRENTLY_ON(BrowserThread::IO);
189 ports_[message_port_id]->SendClosePortMessage(message_port_id); 198 ports_[message_port_id]->SendClosePortMessage(message_port_id);
190 } 199 }
191 200
192 void AwMessagePortServiceImpl::CleanupPort(int message_port_id) { 201 void AppWebMessagePortServiceImpl::CleanupPort(int message_port_id) {
193 DCHECK_CURRENTLY_ON(BrowserThread::IO); 202 DCHECK_CURRENTLY_ON(BrowserThread::IO);
194 ports_.erase(message_port_id); 203 ports_.erase(message_port_id);
195 } 204 }
196 205
197 void AwMessagePortServiceImpl::CreateMessageChannelOnIOThread( 206 void AppWebMessagePortServiceImpl::CreateMessageChannelOnIOThread(
198 scoped_refptr<AwMessagePortMessageFilter> filter, 207 scoped_refptr<AppWebMessagePortMessageFilter> filter,
199 int* portId1, 208 int* portId1,
200 int* portId2) { 209 int* portId2) {
201 MessagePortProvider::CreateMessageChannel(filter.get(), portId1, portId2); 210 *portId1 = 0;
202 MessagePortProvider::HoldMessages(*portId1); 211 *portId2 = 0;
203 MessagePortProvider::HoldMessages(*portId2); 212 MessagePortService* msp = MessagePortService::GetInstance();
213 msp->Create(MSG_ROUTING_NONE, filter.get(), portId1);
214 msp->Create(MSG_ROUTING_NONE, filter.get(), portId2);
215 // Update the routing number of the message ports to be equal to the message
216 // port numbers.
217 msp->UpdateMessagePort(*portId1, filter.get(), *portId1);
218 msp->UpdateMessagePort(*portId2, filter.get(), *portId2);
219 msp->Entangle(*portId1, *portId2);
220 msp->Entangle(*portId2, *portId1);
221
222 msp->HoldMessages(*portId1);
223 msp->HoldMessages(*portId2);
204 AddPort(*portId1, filter.get()); 224 AddPort(*portId1, filter.get());
205 AddPort(*portId2, filter.get()); 225 AddPort(*portId2, filter.get());
206 } 226 }
207 227
208 void AwMessagePortServiceImpl::OnMessageChannelCreated( 228 void AppWebMessagePortServiceImpl::OnMessageChannelCreated(
209 ScopedJavaGlobalRef<jobjectArray>* ports, 229 ScopedJavaGlobalRef<jobjectArray>* ports,
210 int* port1, 230 int* port1,
211 int* port2) { 231 int* port2) {
212 DCHECK_CURRENTLY_ON(BrowserThread::UI); 232 DCHECK_CURRENTLY_ON(BrowserThread::UI);
213 JNIEnv* env = AttachCurrentThread(); 233 JNIEnv* env = AttachCurrentThread();
214 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env); 234 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
215 if (obj.is_null()) 235 if (obj.is_null())
216 return; 236 return;
217 Java_AwMessagePortService_onMessageChannelCreated(env, obj, *port1, *port2, 237 Java_AppWebMessagePortService_onMessageChannelCreated(env, obj,
218 *ports); 238 *port1, *port2,
239 *ports);
219 } 240 }
220 241
221 // Adds a new port to the message port service. 242 // Adds a new port to the message port service.
222 void AwMessagePortServiceImpl::AddPort(int message_port_id, 243 void AppWebMessagePortServiceImpl::AddPort(
223 AwMessagePortMessageFilter* filter) { 244 int message_port_id, AppWebMessagePortMessageFilter* filter) {
224 DCHECK_CURRENTLY_ON(BrowserThread::IO); 245 DCHECK_CURRENTLY_ON(BrowserThread::IO);
225 if (ports_.count(message_port_id)) { 246 if (ports_.count(message_port_id)) {
226 NOTREACHED(); 247 NOTREACHED();
227 return; 248 return;
228 } 249 }
229 ports_[message_port_id] = filter; 250 ports_[message_port_id] = filter;
230 } 251 }
231 252
232 bool RegisterAwMessagePortService(JNIEnv* env) { 253 bool RegisterAppWebMessagePortService(JNIEnv* env) {
233 return RegisterNativesImpl(env); 254 return RegisterNativesImpl(env);
234 } 255 }
235 256
236 // static 257 // static
237 jlong InitAwMessagePortService(JNIEnv* env, const JavaParamRef<jobject>& obj) { 258 jlong InitAppWebMessagePortService(
238 AwMessagePortServiceImpl* service = AwMessagePortServiceImpl::GetInstance(); 259 JNIEnv* env, const JavaParamRef<jobject>& obj) {
260 AppWebMessagePortServiceImpl* service =
261 AppWebMessagePortServiceImpl::GetInstance();
239 service->Init(env, obj); 262 service->Init(env, obj);
240 return reinterpret_cast<intptr_t>(service); 263 return reinterpret_cast<intptr_t>(service);
241 } 264 }
242 265
243 } // namespace android_webview 266 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698