Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2375063002: Revert of Tag checkerboard bitmaps as sRGB (Closed)

Created:
4 years, 2 months ago by Brian Osman
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Tag checkerboard bitmaps as sRGB (patchset #1 id:1 of https://codereview.chromium.org/2368933003/ ) Reason for revert: Regression on displacement GM when sRGB support is lacking. Original issue's description: > Tag checkerboard bitmaps as sRGB > > Significantly reduces the diff between legacy and sRGB/F16 on about 25 > GMs. This is just the biggest piece of low-hanging fruit. Many GMs create > N32 raster surfaces to procedurally generate source textures, and I'd like > to fix all of them. It's much easier to reason about the GMs (is sRGB > doing the right thing) when everything is tagged like this - the only > expected differences are due to filtering and blending. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 > > Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7 TBR=mtklein@google.com,reed@google.com,robertphillips@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b37eb0e968c5082e021244d4baf9b7721e3f360a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/sk_tool_utils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Osman
Created Revert of Tag checkerboard bitmaps as sRGB
4 years, 2 months ago (2016-09-28 14:59:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375063002/1
4 years, 2 months ago (2016-09-28 14:59:58 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 15:17:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b37eb0e968c5082e021244d4baf9b7721e3f360a

Powered by Google App Engine
This is Rietveld 408576698