Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2375053002: fix cubic linear test (Closed)

Created:
4 years, 2 months ago by caryclark
Modified:
4 years, 2 months ago
Reviewers:
_cary, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix cubic linear test Check to see if the line between end points is degenerate before measuring control points. Also, add test case for a bug to see if it shows up on any platform. TBR=reed@google.com BUG=skia:5169, skia:5240 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375053002 Committed: https://skia.googlesource.com/skia/+/e3a4e993ef79788d5ee807b10ff588e9c46bac6d

Patch Set 1 #

Patch Set 2 : use quad code to check cubics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M src/pathops/SkOpBuilder.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyFailTest.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375053002/20001
4 years, 2 months ago (2016-09-28 16:20:58 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 16:22:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e3a4e993ef79788d5ee807b10ff588e9c46bac6d

Powered by Google App Engine
This is Rietveld 408576698