Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: third_party/WebKit/Source/core/paint/SVGShapePainter.cpp

Issue 2375043002: Fix up that no render SVG shape when change clip-path to visible after hidden. (Closed)
Patch Set: Issue 590153 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/SVGShapePainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp b/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp
index fcf37fccb3d9995d511262116eec5df4b9acbf4c..25fe4e7c569cd3f33b00aabb878cc50525bb664a 100644
--- a/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp
+++ b/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp
@@ -51,9 +51,6 @@ void SVGShapePainter::paint(const PaintInfo& paintInfo) {
FloatRect boundingBox =
m_layoutSVGShape.paintInvalidationRectInLocalSVGCoordinates();
- if (!paintInfo.cullRect().intersectsCullRect(
- m_layoutSVGShape.localSVGTransform(), boundingBox))
- return;
PaintInfo paintInfoBeforeFiltering(paintInfo);
// Shapes cannot have children so do not call updateCullRect.
@@ -134,6 +131,10 @@ void SVGShapePainter::paint(const PaintInfo& paintInfo) {
}
}
+ if (!paintInfo.cullRect().intersectsCullRect(
fs 2016/10/31 09:59:22 This does not look like the right fix. Here you're
hyunjunekim2 2016/10/31 13:18:30 I will check it for the right fix.
+ m_layoutSVGShape.localSVGTransform(), boundingBox))
+ return;
+
if (m_layoutSVGShape.style()->outlineWidth()) {
PaintInfo outlinePaintInfo(paintInfoBeforeFiltering);
outlinePaintInfo.phase = PaintPhaseSelfOutlineOnly;

Powered by Google App Engine
This is Rietveld 408576698