third_party/WebKit/LayoutTests/svg/clip-path/clip-path-visible-element-as-visible-shape-element.html - Issue 2375043002: Fix up that no render SVG shape when change clip-path to visible after hidden.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/clip-path/clip-path-visible-element-as-visible-shape-element.html

Issue 2375043002: Fix up that no render SVG shape when change clip-path to visible after hidden. (Closed)

Patch Set: Issue 590153 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/clip-path/clip-path-visible-element-as-visible-shape-element-expected.html » ('j') | third_party/WebKit/Source/core/paint/SVGShapePainter.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <style>

	3 .hidden {

	4 visibility: hidden;

	5 }

	6 </style>

	7 <script>

	8 if (window.testRunner)

	9 testRunner.waitUntilDone();

	10 window.onload = function () {

	11 var classList = document.querySelector("#container").classList;

	12 setTimeout(function() {
	fs 2016/10/31 09:59:22 It looks like it'd be better to use the runAfterLa It looks like it'd be better to use the runAfterLayoutAndPaint helper (from run-after-layout-and-paint.js) or requestAnimationFrame here for the two toggles. Why doesn't starting out with class="hidden" on #container and then only have one toggle() work though? hyunjunekim2 2016/10/31 13:18:30 Done. Show quoted text On 2016/10/31 09:59:22, fs wrote: > It looks like it'd be better to use the runAfterLayoutAndPaint helper (from > run-after-layout-and-paint.js) or requestAnimationFrame here for the two > toggles. Why doesn't starting out with class="hidden" on #container and then > only have one toggle() work though? Done.
	13 classList.toggle("hidden");

	14 setTimeout(function() {

	15 classList.toggle("hidden");

	16 if (window.testRunner)

	17 testRunner.notifyDone();

	18 }, 1);

	19 }, 1);

	20 }

	21 </script>

	22 <div id="container">

	23 <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xl ink" version="1.1" width="400" height="300">
	fs 2016/10/31 09:59:22 You don't need to open/declare namespaces or speci You don't need to open/declare namespaces or specify version. Please remove those three attributes. hyunjunekim2 2016/10/31 13:18:30 Done. Show quoted text On 2016/10/31 09:59:22, fs wrote: > You don't need to open/declare namespaces or specify version. Please remove > those three attributes. Done.
	24 <clipPath id="clip">

	25 <rect width="400" height="400"></rect>

	26 </clipPath>

	27 <rect width="100" height="100" fill="green" visibility="visible" clip-path=" url(#clip)"></rect>
	fs 2016/10/31 09:59:22 I think it'd make more sense to have this <rect> b I think it'd make more sense to have this <rect> be larger and have the <rect> in the clip be smaller so that when the <clipPath> applies the effect on this <rect> is that it is made smaller (is noticably clipped.) hyunjunekim2 2016/10/31 13:18:30 Done. Show quoted text On 2016/10/31 09:59:22, fs wrote: > I think it'd make more sense to have this <rect> be larger and have the <rect> > in the clip be smaller so that when the <clipPath> applies the effect on this > <rect> is that it is made smaller (is noticably clipped.) Done.
	28 </svg>

	29 </div>

OLD	NEW