Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2375023003: Ntp: experiment to initially scroll below the fold. (Closed)

Created:
4 years, 2 months ago by Michael van Ouwerkerk
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer, PEConn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: experiment to initially scroll below the fold. Also deletes custom command line switch as all experiments can be controlled already via: force-fieldtrials enable-features disable-features force-fieldtrial-params Enforces rendering the Most Visited items synchronously during initialization so that the layout is stable and the scroll position can be correctly initialized as well. BUG=649727, 607573 Committed: https://crrev.com/3dc6123ccb4f56866e5e25bee09b850d16ba7729 Cr-Commit-Position: refs/heads/master@{#422069}

Patch Set 1 #

Patch Set 2 : Delete custom command line switch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -78 lines) Patch
M chrome/android/java/res/layout/new_tab_page_layout.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 7 chunks +23 lines, -7 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java View 1 chunk +0 lines, -41 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpStyleUtils.java View 1 chunk +14 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsVariationParameters.java View 1 3 chunks +13 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (18 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
4 years, 2 months ago (2016-09-28 16:08:36 UTC) #6
PEConn
LGTM
4 years, 2 months ago (2016-09-29 14:19:16 UTC) #16
Michael van Ouwerkerk
Bernhard, could you take a look as owner please?
4 years, 2 months ago (2016-09-29 14:22:17 UTC) #18
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-09-30 09:02:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375023003/20001
4 years, 2 months ago (2016-09-30 09:09:06 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 09:14:35 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 09:16:14 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3dc6123ccb4f56866e5e25bee09b850d16ba7729
Cr-Commit-Position: refs/heads/master@{#422069}

Powered by Google App Engine
This is Rietveld 408576698