Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2375013004: MD Settings: hide signin-related UI when signin is disabled (e.g. by policy) (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: hide signin-related UI when signin is disabled (e.g. by policy) R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/15aaee9f3f5d9137bc5864ab923408a409188201 Cr-Commit-Position: refs/heads/master@{#421948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tommycli
lgtm
4 years, 2 months ago (2016-09-29 19:28:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375013004/1
4 years, 2 months ago (2016-09-29 22:00:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 22:06:32 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 22:09:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15aaee9f3f5d9137bc5864ab923408a409188201
Cr-Commit-Position: refs/heads/master@{#421948}

Powered by Google App Engine
This is Rietveld 408576698