Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2375013003: ozone: Remove GLImageOzoneNativePixmapDrm unittest. (Closed)

Created:
4 years, 2 months ago by Daniele Castagna
Modified:
4 years, 2 months ago
Reviewers:
dnicoara, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Remove GLImageOzoneNativePixmapDrm unittest. GLImageOzoneNativePixmapDrm was originally added to test scanout for multi-planar pixmaps (YV12). At the time there was no support to allocate a YV12 pixmap via minigbm, nor to map it and use it in chromium, so the test was explcitily using drm/GEM instead of going trough ozone. It is now possible to use the standard ozone API to allocate and map a YV12 pixmap. A test that uses the standard image test templates for YV12 has also been added to ozone_gl_unittests. (crrev.com/2262353002) GLImageOzoneNativePixmapDrm can now be removed. BUG=618516 Committed: https://crrev.com/3224831384773d0ff664bcf27fd946ac6f39697f Cr-Commit-Position: refs/heads/master@{#421935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -158 lines) Patch
M ui/ozone/gl/BUILD.gn View 3 chunks +0 lines, -15 lines 0 comments Download
D ui/ozone/gl/gl_image_ozone_native_pixmap_drm_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Daniele Castagna
4 years, 2 months ago (2016-09-28 19:03:41 UTC) #4
spang
lgtm
4 years, 2 months ago (2016-09-29 19:55:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375013003/1
4 years, 2 months ago (2016-09-29 20:20:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 21:18:53 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 21:21:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3224831384773d0ff664bcf27fd946ac6f39697f
Cr-Commit-Position: refs/heads/master@{#421935}

Powered by Google App Engine
This is Rietveld 408576698