Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2375013002: Revert of Preparse top-level functions in discardable zones (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Preparse top-level functions in discardable zones (patchset #2 id:20001 of https://codereview.chromium.org/2374963002/ ) Reason for revert: Needed to revert https://codereview.chromium.org/2368313002 which slows down asm.js code Original issue's description: > Preparse top-level functions in discardable zones > > BUG= > > Committed: https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177 > Cr-Commit-Position: refs/heads/master@{#39809} TBR=marja@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/24ae2955ec71c2a1a986f6b918b2de4b157b9f1d Cr-Commit-Position: refs/heads/master@{#39815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -51 lines) Patch
M src/ast/ast.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser.cc View 5 chunks +41 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Toon Verwaest
Created Revert of Preparse top-level functions in discardable zones
4 years, 2 months ago (2016-09-28 09:20:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375013002/1
4 years, 2 months ago (2016-09-28 09:20:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 09:20:52 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 09:21:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24ae2955ec71c2a1a986f6b918b2de4b157b9f1d
Cr-Commit-Position: refs/heads/master@{#39815}

Powered by Google App Engine
This is Rietveld 408576698