Preparse top-level functions in discardable zones

Preparse top-level functions in discardable zones

BUG=

Committed: https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177
Committed: https://crrev.com/375079b1678e7d605b34fdabb2c8adec5c2beb26
Cr-Original-Commit-Position: refs/heads/master@{#39809}
Cr-Commit-Position: refs/heads/master@{#39834}

[Toon Verwaest, 2016-09-28 05:25:18]

verwaest@chromium.org changed reviewers:
+ marja@chromium.org

[Toon Verwaest, 2016-09-28 05:25:19]

ptal

This moves parameter parsing out of the discardable scope, since we'll reuse
them. This regresses what we can throw away in case the function was a
temp-zoned inner function; but this makes it uniform with top-level function
handling. The proper fix is anyway to parse the parameters with the correct
parser in the correct zone, and reparse in case of abort.

[marja, 2016-09-28 07:23:44]

Does this pass the tests (also w/ FLAG_lazy_inner_functions)?

https://codereview.chromium.org/2374963002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2374963002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:2787: use_temp_zone = false;
Why is this correct / enough? So we have parsed into the temp Zone, and
everything created by the PreParser is put there. E.g., PreParser might have
created inner scopes for the current scope... ok, maybe not in practice... but
at least it has put VariableProxys into the Scope (if FLAG_lazy_inner_function
is on). And those are now dangling pointers.

[Toon Verwaest, 2016-09-28 07:44:06]

https://codereview.chromium.org/2374963002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2374963002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:2787: use_temp_zone = false;
On 2016/09/28 07:23:44, marja wrote:
> Why is this correct / enough? So we have parsed into the temp Zone, and
> everything created by the PreParser is put there. E.g., PreParser might have
> created inner scopes for the current scope... ok, maybe not in practice... but
> at least it has put VariableProxys into the Scope (if FLAG_lazy_inner_function
> is on). And those are now dangling pointers.

We ResetAfterPreparsing right above which cleans up everything else?

[marja, 2016-09-28 07:55:42]

lgtm

[Toon Verwaest, 2016-09-28 08:11:35]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-09-28 08:11:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 08:44:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 08:44:51]

Description was changed from

==========
Preparse top-level functions in discardable zones

BUG=
==========

to

==========
Preparse top-level functions in discardable zones

BUG=

Committed: https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177
Cr-Commit-Position: refs/heads/master@{#39809}
==========

[commit-bot: I haz the power, 2016-09-28 08:44:53]

Patchset 2 (id:??) landed as
https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177
Cr-Commit-Position: refs/heads/master@{#39809}

[Toon Verwaest, 2016-09-28 09:20:40]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2375013002/ by verwaest@chromium.org.

The reason for reverting is: Needed to revert
https://codereview.chromium.org/2368313002 which slows down asm.js code.

[Toon Verwaest, 2016-09-28 15:02:05]

Description was changed from

==========
Preparse top-level functions in discardable zones

BUG=

Committed: https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177
Cr-Commit-Position: refs/heads/master@{#39809}
==========

to

==========
Preparse top-level functions in discardable zones

BUG=

Committed: https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177
Cr-Commit-Position: refs/heads/master@{#39809}
==========

[Toon Verwaest, 2016-09-28 15:02:14]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-09-28 15:02:14]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2374963002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-28 15:02:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 15:58:28]

Description was changed from

==========
Preparse top-level functions in discardable zones

BUG=

Committed: https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177
Cr-Commit-Position: refs/heads/master@{#39809}
==========

to

==========
Preparse top-level functions in discardable zones

BUG=

Committed: https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177
Cr-Commit-Position: refs/heads/master@{#39809}
==========

[commit-bot: I haz the power, 2016-09-28 15:58:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-28 15:58:48]

Description was changed from

==========
Preparse top-level functions in discardable zones

BUG=

Committed: https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177
Cr-Commit-Position: refs/heads/master@{#39809}
==========

to

==========
Preparse top-level functions in discardable zones

BUG=

Committed: https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177
Committed: https://crrev.com/375079b1678e7d605b34fdabb2c8adec5c2beb26
Cr-Original-Commit-Position: refs/heads/master@{#39809}
Cr-Commit-Position: refs/heads/master@{#39834}
==========

[commit-bot: I haz the power, 2016-09-28 15:58:50]

Patchset 3 (id:??) landed as
https://crrev.com/375079b1678e7d605b34fdabb2c8adec5c2beb26
Cr-Commit-Position: refs/heads/master@{#39834}