Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issue 2374943002: Add Android, Linux and Mac debug builder for deterministic build. (Closed)

Created:
4 years, 2 months ago by Yoshisato Yanagisawa
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Android, Linux and Mac debug builder for deterministic build. BUG=314403 Committed: https://crrev.com/6c0025a991117815b2700ecb800eb06bab1870e2 Cr-Commit-Position: refs/heads/master@{#422727}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use android_debug_bot instead. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Yoshisato Yanagisawa
Let me also check build determinism on Linux, Android, Mac debug build.
4 years, 2 months ago (2016-09-28 04:28:53 UTC) #2
Dirk Pranke
https://codereview.chromium.org/2374943002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2374943002/diff/1/tools/mb/mb_config.pyl#newcode81 tools/mb/mb_config.pyl:81: 'Android deterministic (dbg)': 'android_debug_static_bot_x86', why x86? If you don't ...
4 years, 2 months ago (2016-09-28 16:17:21 UTC) #3
Yoshisato Yanagisawa
https://codereview.chromium.org/2374943002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2374943002/diff/1/tools/mb/mb_config.pyl#newcode81 tools/mb/mb_config.pyl:81: 'Android deterministic (dbg)': 'android_debug_static_bot_x86', done. I want a general ...
4 years, 2 months ago (2016-09-29 00:48:46 UTC) #4
Yoshisato Yanagisawa
PTAL
4 years, 2 months ago (2016-10-04 02:35:00 UTC) #5
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-04 04:20:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374943002/40001
4 years, 2 months ago (2016-10-04 05:59:40 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-04 07:03:09 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 07:05:40 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6c0025a991117815b2700ecb800eb06bab1870e2
Cr-Commit-Position: refs/heads/master@{#422727}

Powered by Google App Engine
This is Rietveld 408576698