Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2374923002: Avoid crashing for cases when cell/row parenting is not like a real table. (Closed)

Created:
4 years, 2 months ago by chrishtr
Modified:
4 years, 2 months ago
Reviewers:
wkorman
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid crashing for cases when cell/row parenting is not like a real table. BUG=650877 Committed: https://crrev.com/c92b29db029d52d6423835f13741112867a3c00d Cr-Commit-Position: refs/heads/master@{#421429}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/display-table-row-crash.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/paint/invalidation/display-table-row-crash-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
chrishtr
4 years, 2 months ago (2016-09-28 00:11:47 UTC) #3
wkorman
lgtm Is the BUG= the right bug? Looks like it's for a different one re: ...
4 years, 2 months ago (2016-09-28 00:25:14 UTC) #9
chrishtr
On 2016/09/28 at 00:25:14, wkorman wrote: > lgtm > > Is the BUG= the right ...
4 years, 2 months ago (2016-09-28 00:41:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374923002/40001
4 years, 2 months ago (2016-09-28 00:42:24 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-28 02:26:17 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 02:28:49 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c92b29db029d52d6423835f13741112867a3c00d
Cr-Commit-Position: refs/heads/master@{#421429}

Powered by Google App Engine
This is Rietveld 408576698