Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 23749007: Views: Fix keyboard input in linux_aura. (Closed)

Created:
7 years, 3 months ago by Elliot Glaysher
Modified:
7 years, 3 months ago
Reviewers:
yukawa, Seigo Nonaka
CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Views: Fix keyboard input in linux_aura. Revert "Do nothing unless the attached widget is active in InputMethodBridge::OnFocus". This reverts commit r222304. BUG=287620, 291256 R=nona@chromium.org, yukawa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223358

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -18 lines) Patch
M ui/views/ime/input_method_base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/ime/input_method_base.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M ui/views/ime/input_method_bridge.cc View 4 chunks +3 lines, -6 lines 3 comments Download

Messages

Total messages: 5 (0 generated)
yukawa
lgtm OK from my side to commit this revert patch. Nona, could you approve this ...
7 years, 3 months ago (2013-09-14 07:04:17 UTC) #1
Seigo Nonaka
lgtm
7 years, 3 months ago (2013-09-15 02:55:02 UTC) #2
Seigo Nonaka
https://codereview.chromium.org/23749007/diff/1/ui/views/ime/input_method_bridge.cc File ui/views/ime/input_method_bridge.cc (right): https://codereview.chromium.org/23749007/diff/1/ui/views/ime/input_method_bridge.cc#newcode85 ui/views/ime/input_method_bridge.cc:85: return host_->OnInputLocaleChanged(); nit: You are returning void value, Is ...
7 years, 3 months ago (2013-09-15 03:22:58 UTC) #3
yukawa
https://codereview.chromium.org/23749007/diff/1/ui/views/ime/input_method_bridge.cc File ui/views/ime/input_method_bridge.cc (right): https://codereview.chromium.org/23749007/diff/1/ui/views/ime/input_method_bridge.cc#newcode85 ui/views/ime/input_method_bridge.cc:85: return host_->OnInputLocaleChanged(); On 2013/09/15 03:22:59, Seigo Nonaka wrote: > ...
7 years, 3 months ago (2013-09-15 05:07:27 UTC) #4
Elliot Glaysher
7 years, 3 months ago (2013-09-16 17:58:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r223358 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698