Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 23749003: Protect WebRTC code in content/renderer (Closed)

Created:
7 years, 3 months ago by kjellander_chromium
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Protect WebRTC code in content/renderer When compiling in Debug mode Win7/MSVS 2010 using GYP_DEFINES="enable_webrtc=0 component=shared_library" the compilation fails. This CL ensures these files are not included when enable_webrtc=0. BUG=284083 TEST=local compile. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222015

Patch Set 1 #

Total comments: 4

Patch Set 2 : Moved the include according to reviewer suggestion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M content/renderer/render_frame_impl.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
kjellander_chromium
I'm pretty sure those trybot test failures have nothing to do with this change.
7 years, 3 months ago (2013-09-04 13:24:49 UTC) #1
Tommy Widenflycht
lgtm
7 years, 3 months ago (2013-09-05 07:34:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/23749003/1
7 years, 3 months ago (2013-09-05 08:04:48 UTC) #3
kjellander_chromium
James: may I have rubberstamp lg?
7 years, 3 months ago (2013-09-05 08:09:17 UTC) #4
jamesr
lgtm if you fix the include order https://codereview.chromium.org/23749003/diff/1/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/23749003/diff/1/content/renderer/render_frame_impl.cc#newcode25 content/renderer/render_frame_impl.cc:25: #if defined(ENABLE_WEBRTC) ...
7 years, 3 months ago (2013-09-06 22:39:57 UTC) #5
kjellander_chromium
Thanks, sorry for not paying more attention in the first patch set. Now I've moved ...
7 years, 3 months ago (2013-09-09 09:26:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/23749003/13001
7 years, 3 months ago (2013-09-09 09:26:18 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 12:49:23 UTC) #8
Message was sent while issue was closed.
Change committed as 222015

Powered by Google App Engine
This is Rietveld 408576698