Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2374873002: Update GN bootstrap file list. (Closed)

Created:
4 years, 2 months ago by Dirk Pranke
Modified:
4 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update GN bootstrap file list. This updates the GN bootstrap build to reflect recent changes in //base: - //base/files/file_descriptor_watcher_posix.cc was added - //base/memory/ref_counted was re-added - //base/trace_event/winheap_dump_provider_win.cc was removed. R=brettw@chromium.org Committed: https://crrev.com/fec688caede93a05edadb944246d5a46f94ec615 Cr-Commit-Position: refs/heads/master@{#421381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gn/bootstrap/bootstrap.py View 3 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
It is annoying to have to manually check this ... I wonder if there's some ...
4 years, 2 months ago (2016-09-27 22:56:07 UTC) #1
brettw
lgtm
4 years, 2 months ago (2016-09-27 22:58:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374873002/1
4 years, 2 months ago (2016-09-27 23:00:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 23:11:47 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 23:13:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fec688caede93a05edadb944246d5a46f94ec615
Cr-Commit-Position: refs/heads/master@{#421381}

Powered by Google App Engine
This is Rietveld 408576698