Cleanup Semaphore class.

test/cctest/test-sockets.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 23 matching lines @@
 
 
 class SocketListenerThread : public Thread {
  public:
   SocketListenerThread(int port, int data_size)
       : Thread("SocketListenerThread"),
         port_(port),
         data_size_(data_size),
         server_(NULL),
         client_(NULL),
-        listening_(OS::CreateSemaphore(0)) {
+        listening_(0) {
     data_ = new char[data_size_];
   }
   ~SocketListenerThread() {
     // Close both sockets.
     delete client_;
     delete server_;
-    delete listening_;
     delete[] data_;
   }
 
   void Run();
-  void WaitForListening() { listening_->Wait(); }
+  void WaitForListening() { listening_.Wait(); }
   char* data() { return data_; }
 
  private:
   int port_;
   char* data_;
   int data_size_;
   Socket* server_;  // Server socket used for bind/accept.
   Socket* client_;  // Single client connection used by the test.
-  Semaphore* listening_;  // Signalled when the server socket is in listen mode.
+  Semaphore listening_;  // Signalled when the server socket is in listen mode.
 };
 
 
 void SocketListenerThread::Run() {
   bool ok;
 
   // Create the server socket and bind it to the requested port.
   server_ = OS::CreateSocket();
   server_->SetReuseAddress(true);
   CHECK(server_ != NULL);
   ok = server_->Bind(port_);
   CHECK(ok);
 
   // Listen for new connections.
   ok = server_->Listen(1);
   CHECK(ok);
-  listening_->Signal();
+  listening_.Signal();
 
   // Accept a connection.
   client_ = server_->Accept();
   CHECK(client_ != NULL);
 
   // Read the expected niumber of bytes of data.
   int bytes_read = 0;
   while (bytes_read < data_size_) {
     bytes_read += client_->Receive(data_ + bytes_read, data_size_ - bytes_read);
   }
@@ skipping 89 matching lines @@
 }
 
 
 TEST(HToNNToH) {
   uint16_t x = 1234;
   CHECK_EQ(x, Socket::NToH(Socket::HToN(x)));
 
   uint32_t y = 12345678;
   CHECK(y == Socket::NToH(Socket::HToN(y)));
 }