Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: src/marking-thread.cc

Issue 23748003: Cleanup Semaphore class. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Build fix for Mac OS X. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/marking-thread.h ('k') | src/optimizing-compiler-thread.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 21 matching lines...) Expand all
32 #include "isolate.h" 32 #include "isolate.h"
33 #include "v8threads.h" 33 #include "v8threads.h"
34 34
35 namespace v8 { 35 namespace v8 {
36 namespace internal { 36 namespace internal {
37 37
38 MarkingThread::MarkingThread(Isolate* isolate) 38 MarkingThread::MarkingThread(Isolate* isolate)
39 : Thread("MarkingThread"), 39 : Thread("MarkingThread"),
40 isolate_(isolate), 40 isolate_(isolate),
41 heap_(isolate->heap()), 41 heap_(isolate->heap()),
42 start_marking_semaphore_(OS::CreateSemaphore(0)), 42 start_marking_semaphore_(0),
43 end_marking_semaphore_(OS::CreateSemaphore(0)), 43 end_marking_semaphore_(0),
44 stop_semaphore_(OS::CreateSemaphore(0)) { 44 stop_semaphore_(0) {
45 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(false)); 45 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(false));
46 id_ = NoBarrier_AtomicIncrement(&id_counter_, 1); 46 id_ = NoBarrier_AtomicIncrement(&id_counter_, 1);
47 } 47 }
48 48
49 49
50 Atomic32 MarkingThread::id_counter_ = -1; 50 Atomic32 MarkingThread::id_counter_ = -1;
51 51
52 52
53 void MarkingThread::Run() { 53 void MarkingThread::Run() {
54 Isolate::SetIsolateThreadLocals(isolate_, NULL); 54 Isolate::SetIsolateThreadLocals(isolate_, NULL);
55 DisallowHeapAllocation no_allocation; 55 DisallowHeapAllocation no_allocation;
56 DisallowHandleAllocation no_handles; 56 DisallowHandleAllocation no_handles;
57 DisallowHandleDereference no_deref; 57 DisallowHandleDereference no_deref;
58 58
59 while (true) { 59 while (true) {
60 start_marking_semaphore_->Wait(); 60 start_marking_semaphore_.Wait();
61 61
62 if (Acquire_Load(&stop_thread_)) { 62 if (Acquire_Load(&stop_thread_)) {
63 stop_semaphore_->Signal(); 63 stop_semaphore_.Signal();
64 return; 64 return;
65 } 65 }
66 66
67 end_marking_semaphore_->Signal(); 67 end_marking_semaphore_.Signal();
68 } 68 }
69 } 69 }
70 70
71 71
72 void MarkingThread::Stop() { 72 void MarkingThread::Stop() {
73 Release_Store(&stop_thread_, static_cast<AtomicWord>(true)); 73 Release_Store(&stop_thread_, static_cast<AtomicWord>(true));
74 start_marking_semaphore_->Signal(); 74 start_marking_semaphore_.Signal();
75 stop_semaphore_->Wait(); 75 stop_semaphore_.Wait();
76 Join(); 76 Join();
77 } 77 }
78 78
79 79
80 void MarkingThread::StartMarking() { 80 void MarkingThread::StartMarking() {
81 start_marking_semaphore_->Signal(); 81 start_marking_semaphore_.Signal();
82 } 82 }
83 83
84 84
85 void MarkingThread::WaitForMarkingThread() { 85 void MarkingThread::WaitForMarkingThread() {
86 end_marking_semaphore_->Wait(); 86 end_marking_semaphore_.Wait();
87 } 87 }
88 88
89 } } // namespace v8::internal 89 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/marking-thread.h ('k') | src/optimizing-compiler-thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698