[Downloads] Fix UMA recording of invalid results from AttachmentServices

[Downloads] Fix UMA recording of invalid results from AttachmentServices

Also cleanup quarantine_win_unittest.cc while we are here.

BUG=427616
Committed: https://crrev.com/a50396779e6a75d0d310a414d85fd845b5736d7e
Cr-Commit-Position: refs/heads/master@{#421550}

[asanka, 2016-09-27 20:05:10]

asanka@chromium.org changed reviewers:
+ svaldez@chromium.org

[asanka, 2016-09-27 20:05:10]

This is to address
https://codereview.chromium.org/2123023002/diff/240001/content/browser/downlo...

[svaldez, 2016-09-27 20:11:04]

lgtm

https://codereview.chromium.org/2374793002/diff/1/content/browser/download/qu...
File content/browser/download/quarantine_win_unittest.cc (right):

https://codereview.chromium.org/2374793002/diff/1/content/browser/download/qu...
content/browser/download/quarantine_win_unittest.cc:32: const char kTestData[] =
{
Any reason not to do (if it works):

const char kTestData[] = "Hello world!\r\n";

[asanka, 2016-09-27 20:18:55]

The CQ bit was checked by asanka@chromium.org

[asanka, 2016-09-27 20:18:55]

The patchset sent to the CQ was uploaded after l-g-t-m from svaldez@chromium.org
Link to the patchset: https://codereview.chromium.org/2374793002/#ps20001
(title: "Simplify test")

[asanka, 2016-09-27 20:19:18]

https://codereview.chromium.org/2374793002/diff/1/content/browser/download/qu...
File content/browser/download/quarantine_win_unittest.cc (right):

https://codereview.chromium.org/2374793002/diff/1/content/browser/download/qu...
content/browser/download/quarantine_win_unittest.cc:32: const char kTestData[] =
{
On 2016/09/27 at 20:11:03, svaldez wrote:
> Any reason not to do (if it works):
> 
> const char kTestData[] = "Hello world!\r\n";

None other than avoiding the terminating NUL.

I'll simplify this since the string being written is irrelevant to the test. The
file just can't be empty.

[commit-bot: I haz the power, 2016-09-27 20:19:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-09-27 20:37:21]

Description was changed from

==========
[Downloads] Fix UMA recording of invalid results from AttachmentServices

Also cleanup quarantine_win_unittest.cc while we are here.

BUG=none
==========

to

==========
[Downloads] Fix UMA recording of invalid results from AttachmentServices

Also cleanup quarantine_win_unittest.cc while we are here.

BUG=427616
==========

[brucedawson, 2016-09-27 20:38:10]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2016-09-27 20:38:11]

lgtm

I edited the description to add the /analyze tracking bug 427616 since that is
what found the bug (in a circuitous way)

[commit-bot: I haz the power, 2016-09-27 21:24:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 21:24:37]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[asanka, 2016-09-28 16:14:29]

The CQ bit was checked by asanka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 16:14:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 16:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 16:57:40]

Dry run: This issue passed the CQ dry run.

[asanka, 2016-09-28 17:02:33]

The CQ bit was checked by asanka@chromium.org

[asanka, 2016-09-28 17:02:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
svaldez@chromium.org, brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/2374793002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-09-28 17:02:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 17:10:08]

Description was changed from

==========
[Downloads] Fix UMA recording of invalid results from AttachmentServices

Also cleanup quarantine_win_unittest.cc while we are here.

BUG=427616
==========

to

==========
[Downloads] Fix UMA recording of invalid results from AttachmentServices

Also cleanup quarantine_win_unittest.cc while we are here.

BUG=427616
==========

[commit-bot: I haz the power, 2016-09-28 17:10:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-28 17:14:56]

Description was changed from

==========
[Downloads] Fix UMA recording of invalid results from AttachmentServices

Also cleanup quarantine_win_unittest.cc while we are here.

BUG=427616
==========

to

==========
[Downloads] Fix UMA recording of invalid results from AttachmentServices

Also cleanup quarantine_win_unittest.cc while we are here.

BUG=427616

Committed: https://crrev.com/a50396779e6a75d0d310a414d85fd845b5736d7e
Cr-Commit-Position: refs/heads/master@{#421550}
==========

[commit-bot: I haz the power, 2016-09-28 17:14:57]

Patchset 3 (id:??) landed as
https://crrev.com/a50396779e6a75d0d310a414d85fd845b5736d7e
Cr-Commit-Position: refs/heads/master@{#421550}