Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: third_party/WebKit/Source/core/dom/DOMMatrix.h

Issue 2374773002: [GeometryInterface] Add DOMMatrix(numberSequence) constructor. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DOMMatrix.h
diff --git a/third_party/WebKit/Source/core/dom/DOMMatrix.h b/third_party/WebKit/Source/core/dom/DOMMatrix.h
index 1ad7fadee155c70ba0ee90376ed81c2117d0c235..e9608816dde1a0d6eb17a191f3510a4f5934af5d 100644
--- a/third_party/WebKit/Source/core/dom/DOMMatrix.h
+++ b/third_party/WebKit/Source/core/dom/DOMMatrix.h
@@ -5,6 +5,7 @@
#ifndef DOMMatrix_h
#define DOMMatrix_h
+#include "bindings/core/v8/ExceptionStatePlaceholder.h"
#include "core/dom/DOMMatrixInit.h"
#include "core/dom/DOMMatrixReadOnly.h"
@@ -13,9 +14,10 @@ namespace blink {
class CORE_EXPORT DOMMatrix : public DOMMatrixReadOnly {
DEFINE_WRAPPERTYPEINFO();
public:
- static DOMMatrix* create();
- static DOMMatrix* create(DOMMatrixReadOnly*);
- static DOMMatrix* create(const SkMatrix44&);
+ static DOMMatrix* create(ExceptionState&);
+ static DOMMatrix* create(DOMMatrixReadOnly*, ExceptionState& = ASSERT_NO_EXCEPTION);
zino 2016/09/27 17:53:33 nit: Do we need this default parameter?
Hwanseung Lee 2016/09/27 18:06:28 this function invoked many other function(ex. flip
zino 2016/09/28 16:20:49 Oh, I didn't know. good to me.
+ static DOMMatrix* create(const SkMatrix44&, ExceptionState&);
+ static DOMMatrix* create(Vector<double>, ExceptionState&);
static DOMMatrix* fromFloat32Array(DOMFloat32Array*, ExceptionState&);
static DOMMatrix* fromFloat64Array(DOMFloat64Array*, ExceptionState&);
static DOMMatrix* fromMatrix(DOMMatrixInit&, ExceptionState&);
« no previous file with comments | « third_party/WebKit/Source/core/dom/CompositorProxy.cpp ('k') | third_party/WebKit/Source/core/dom/DOMMatrix.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698