Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2374773002: [GeometryInterface] Add DOMMatrix(numberSequence) constructor. (Closed)

Created:
4 years, 2 months ago by Hwanseung Lee
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Hwanseung Lee(hs1217.lee), rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GeometryInterface] Add DOMMatrix(numberSequence) constructor. Return the result of invoking create a matrix of type DOMMatrix, with the sequence numberSequence. spec list: https://drafts.fxtf.org/geometry/#dom-dommatrix-dommatrix-numbersequence BUG=388780 Committed: https://crrev.com/11e1472d10abeaa066cb9928154a4a76698366b5 Cr-Commit-Position: refs/heads/master@{#421724}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -27 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-invert.html View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-skew.html View 1 chunk +8 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.h View 2 chunks +5 lines, -3 lines 3 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.cpp View 1 chunk +12 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
Hwanseung Lee
@zino PTAL. thank you.
4 years, 2 months ago (2016-09-27 17:49:14 UTC) #3
zino
On 2016/09/27 17:49:14, Hwanseung Lee wrote: > @zino PTAL. thank you. lgtm with nit.
4 years, 2 months ago (2016-09-27 17:52:21 UTC) #4
zino
+ Justin Novosad for core owner review. Please take a look. https://codereview.chromium.org/2374773002/diff/1/third_party/WebKit/Source/core/dom/DOMMatrix.h File third_party/WebKit/Source/core/dom/DOMMatrix.h (right): ...
4 years, 2 months ago (2016-09-27 17:53:34 UTC) #6
Hwanseung Lee
@zino. please refer to my comment. https://codereview.chromium.org/2374773002/diff/1/third_party/WebKit/Source/core/dom/DOMMatrix.h File third_party/WebKit/Source/core/dom/DOMMatrix.h (right): https://codereview.chromium.org/2374773002/diff/1/third_party/WebKit/Source/core/dom/DOMMatrix.h#newcode18 third_party/WebKit/Source/core/dom/DOMMatrix.h:18: static DOMMatrix* create(DOMMatrixReadOnly*, ...
4 years, 2 months ago (2016-09-27 18:06:28 UTC) #7
zino
https://codereview.chromium.org/2374773002/diff/1/third_party/WebKit/Source/core/dom/DOMMatrix.h File third_party/WebKit/Source/core/dom/DOMMatrix.h (right): https://codereview.chromium.org/2374773002/diff/1/third_party/WebKit/Source/core/dom/DOMMatrix.h#newcode18 third_party/WebKit/Source/core/dom/DOMMatrix.h:18: static DOMMatrix* create(DOMMatrixReadOnly*, ExceptionState& = ASSERT_NO_EXCEPTION); On 2016/09/27 18:06:28, ...
4 years, 2 months ago (2016-09-28 16:20:49 UTC) #9
Justin Novosad
I have no objections. However, I am not sufficiently familiar with this area of the ...
4 years, 2 months ago (2016-09-28 19:56:26 UTC) #10
dominicc (has gone to gerrit)
lgtm Splendid work.
4 years, 2 months ago (2016-09-29 01:29:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374773002/1
4 years, 2 months ago (2016-09-29 02:34:23 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 02:41:32 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 02:43:30 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11e1472d10abeaa066cb9928154a4a76698366b5
Cr-Commit-Position: refs/heads/master@{#421724}

Powered by Google App Engine
This is Rietveld 408576698