[GeometryInterface] Add DOMMatrix(numberSequence) constructor.

[GeometryInterface] Add DOMMatrix(numberSequence) constructor.

Return the result of invoking create a matrix of type
DOMMatrix, with the sequence numberSequence.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrix-dommatrix-numbersequence

BUG=388780
Committed: https://crrev.com/11e1472d10abeaa066cb9928154a4a76698366b5
Cr-Commit-Position: refs/heads/master@{#421724}

[Hwanseung Lee, 2016-09-27 17:46:11]

Description was changed from

==========
[GeometryInterface] Add DOMMatrix(numberSequence) constructor.

Return the result of invoking create a matrix of type
DOMMatrix, with the sequence numberSequence.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrix-dommatrix-numbersequence

BUG=388780
==========

to

==========
[GeometryInterface] Add DOMMatrix(numberSequence) constructor.

Return the result of invoking create a matrix of type
DOMMatrix, with the sequence numberSequence.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrix-dommatrix-numbersequence

BUG=388780
==========

[Hwanseung Lee, 2016-09-27 17:46:11]

hs1217.lee@samsung.com changed reviewers:
+ jinho.bang@samsung.com

[Hwanseung Lee, 2016-09-27 17:49:14]

@zino PTAL. thank you.

[zino, 2016-09-27 17:52:21]

On 2016/09/27 17:49:14, Hwanseung Lee wrote:
> @zino PTAL. thank you.

lgtm with nit.

[zino, 2016-09-27 17:52:48]

jinho.bang@samsung.com changed reviewers:
+ junov@chromium.org

[zino, 2016-09-27 17:53:34]

+ Justin Novosad for core owner review.

Please take a look.

https://codereview.chromium.org/2374773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/DOMMatrix.h (right):

https://codereview.chromium.org/2374773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DOMMatrix.h:18: static DOMMatrix*
create(DOMMatrixReadOnly*, ExceptionState& = ASSERT_NO_EXCEPTION);
nit: Do we need this default parameter?

[Hwanseung Lee, 2016-09-27 18:06:28]

@zino.
please refer to my comment.

https://codereview.chromium.org/2374773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/DOMMatrix.h (right):

https://codereview.chromium.org/2374773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DOMMatrix.h:18: static DOMMatrix*
create(DOMMatrixReadOnly*, ExceptionState& = ASSERT_NO_EXCEPTION);
this function invoked many other function(ex. flipX, skewX ...) at
DomMatrixReadOnly.
that function can't pass value of ExceptionState.

[Hwanseung Lee, 2016-09-28 08:19:03]

hs1217.lee@samsung.com changed reviewers:
+ dominicc@chromium.org

[zino, 2016-09-28 16:20:49]

https://codereview.chromium.org/2374773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/DOMMatrix.h (right):

https://codereview.chromium.org/2374773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DOMMatrix.h:18: static DOMMatrix*
create(DOMMatrixReadOnly*, ExceptionState& = ASSERT_NO_EXCEPTION);
On 2016/09/27 18:06:28, Hwanseung Lee wrote:
> this function invoked many other function(ex. flipX, skewX ...) at
> DomMatrixReadOnly.
> that function can't pass value of ExceptionState.

Oh, I didn't know. good to me.

[Justin Novosad, 2016-09-28 19:56:26]

I have no objections. However, I am not sufficiently familiar with this area of
the code or this feature.  Deferring to dominicc@ for approval.

[dominicc (has gone to gerrit), 2016-09-29 01:28:42]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[dominicc (has gone to gerrit), 2016-09-29 01:29:03]

lgtm

Splendid work.

[commit-bot: I haz the power, 2016-09-29 01:29:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 02:32:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 02:32:22]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2016-09-29 02:34:09]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-09-29 02:34:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 02:41:31]

Description was changed from

==========
[GeometryInterface] Add DOMMatrix(numberSequence) constructor.

Return the result of invoking create a matrix of type
DOMMatrix, with the sequence numberSequence.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrix-dommatrix-numbersequence

BUG=388780
==========

to

==========
[GeometryInterface] Add DOMMatrix(numberSequence) constructor.

Return the result of invoking create a matrix of type
DOMMatrix, with the sequence numberSequence.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrix-dommatrix-numbersequence

BUG=388780
==========

[commit-bot: I haz the power, 2016-09-29 02:41:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-29 02:43:29]

Description was changed from

==========
[GeometryInterface] Add DOMMatrix(numberSequence) constructor.

Return the result of invoking create a matrix of type
DOMMatrix, with the sequence numberSequence.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrix-dommatrix-numbersequence

BUG=388780
==========

to

==========
[GeometryInterface] Add DOMMatrix(numberSequence) constructor.

Return the result of invoking create a matrix of type
DOMMatrix, with the sequence numberSequence.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrix-dommatrix-numbersequence

BUG=388780

Committed: https://crrev.com/11e1472d10abeaa066cb9928154a4a76698366b5
Cr-Commit-Position: refs/heads/master@{#421724}
==========

[commit-bot: I haz the power, 2016-09-29 02:43:30]

Patchset 1 (id:??) landed as
https://crrev.com/11e1472d10abeaa066cb9928154a4a76698366b5
Cr-Commit-Position: refs/heads/master@{#421724}